docs(create-github-app-token): fix some errors in readme (#1558)

* fix(create-github-app-token): fix some errors in readme

* Fix typo in permission_set parameter

Author: eloymg

actions/create-github-app-token/README.md

@@ -7,14 +7,14 @@ From a `grafana/` org repository, get a ephemeral GitHub API token from a GitHub
 | Name             | Type   | Description                 | Default Value | Required |
 | ---------------- | ------ | --------------------------- | ------------- | -------- |
 | `permission_set` | String | The required permission set | `default`     | Yes      |
-| `github-app`     | String | The required GitHub app     |               | Yes      |
+| `github_app`     | String | The required GitHub app     |               | Yes      |
 | `vault_instance` | String | Vault instance to point     | `ops`         | No       |
 
 ## Outputs
 
-| Name           | Type   | Description                |
-| -------------- | ------ | -------------------------- |
-| `github_token` | String | The generated GitHub token |
+| Name    | Type   | Description                |
+| ------- | ------ | -------------------------- |
+| `token` | String | The generated GitHub token |
 
 ## Examples
 
@@ -49,7 +49,7 @@ jobs:
         run: |
           curl -L \
             -H "Accept: application/vnd.github+json" \
-            -H "Authorization: Bearer ${{ steps.get-github-token.outputs.github_token }}" \
+            -H "Authorization: Bearer ${{ steps.get-github-token.outputs.token }}" \
             -H "X-GitHub-Api-Version: 2022-11-28" \
             https://api.github.com/repos/grafana/grafana/assignees
 ```
@@ -75,30 +75,30 @@ jobs:
         uses: grafana/shared-workflows/actions/create-github-app-token@create-github-app-token/v0.2.2
         with:
           github_app: github-app-name
-          permissions-set: read-only-on-foo-repository
+          permission_set: read-only-on-foo-repository
 
       # Use the secrets
       - name: list issues assignees
         run: |
           curl -L \
             -H "Accept: application/vnd.github+json" \
-            -H "Authorization: Bearer ${{ steps.get-github-token-read.outputs.github_token }}" \
+            -H "Authorization: Bearer ${{ steps.get-github-token-read.outputs.token }}" \
             -H "X-GitHub-Api-Version: 2022-11-28" \
             https://api.github.com/repos/grafana/foo-repository/assignees
 
       - id: get-github-token-write
         uses: grafana/shared-workflows/actions/create-github-app-token@create-github-app-token/v0.2.2
         with:
           github_app: github-app-name
-          permissions-set: write-on-bar-repository
+          permission_set: write-on-bar-repository
 
       # Use the secrets
       - name: create a pull request
         run: |
           curl -L \
             -X POST \
             -H "Accept: application/vnd.github+json" \
-            -H "Authorization: Bearer ${{ steps.get-github-token-write.outputs.github_token }}" \
+            -H "Authorization: Bearer ${{ steps.get-github-token-write.outputs.token }}" \
             -H "X-GitHub-Api-Version: 2022-11-28" \
             https://api.github.com/repos/grafana/bar-repository/pulls \
             -d '{"title":"Amazing new feature","body":"Please pull these awesome changes in!","head":"octocat:new-feature","base":"master"}'