Use the tenant package from dskit #1599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
johannaratliff
approved these changes
Mar 31, 2022
Contributor
|
Please note that there is already #1587 in progress that updates dskit. There is still one problem to fix (with advanced flags). |
56quarters
force-pushed
the
56quarters/dskit-tenant
branch
from
5ee42d7 to
eedb38b
Compare
Contributor
|
If you merge this, I can also rebase my PR and fix remaining problems there. |
Contributor
Author
Will merge this as-is and let @pstibrany fix remaining problems. |
This is required because Mimir sets a default resolver based on if tenant federation is enabled. However, GEM has already updated to the dskit resolver and so doesn't use the correct or same resolver that Mimir is. Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
force-pushed
the
56quarters/dskit-tenant
branch
from
eedb38b to
f3d4c2d
Compare
dimitarvdimitrov
added a commit
that referenced
this pull request
Apr 1, 2022
pracucci
pushed a commit
that referenced
this pull request
Apr 1, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required because Mimir sets a default resolver based on if
tenant federation is enabled. However, GEM has already updated to the
dskit resolver and so doesn't use the correct or same resolver that
Mimir is.
Signed-off-by: Nick Pillitteri [email protected]
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]