Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Uneven partition distributions can lead to inconsistent results #1506

Closed
replay opened this issue Oct 23, 2019 · 4 comments
Closed

Uneven partition distributions can lead to inconsistent results #1506

replay opened this issue Oct 23, 2019 · 4 comments
Labels

Comments

@replay
Copy link
Contributor

replay commented Oct 23, 2019

While a cluster of Metrictanks is in a state where its partitions are distributed unequally between instances, there can be situations where finds using speculative query execution result in incomplete results.

We're currently using the first partition of each Metrictank as an identifier for its partition group, assuming that all Metrictanks which have the same first partition have all the same partitions

membersMap[memberStartPartition] = append(membersMap[memberStartPartition], member)

In a situation where the partition distribution is unequal, this can result in partitions being omitted when executing cluster wide finds.
For example:

Metrictank0: 4,5,6,7
Metrictank1: 4,5

It is possible that a /find call would end up on Metrictank1 and the partitions 6,7 would get omitted.

@shanson7
Copy link
Collaborator

Yes, this was brought up during the implementation. See #956 (comment)

@replay
Copy link
Contributor Author

replay commented Oct 24, 2019

Good point. In the meantime our requirements have changed, so we're now looking for a way to make that work.

@stale
Copy link

stale bot commented Apr 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 4, 2020
@Dieterbe
Copy link
Contributor

This is not an actual issue. Just something we'd like to improve

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants