Support building against Go 1.19 #6833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes grafana#6831 Hat-tip to @rfratto in grafana/agent#1985 Signed-off-by: Danny Kopping <[email protected]>
periklis
approved these changes
Aug 3, 2022
Contributor
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
Signed-off-by: Danny Kopping <[email protected]>
trevorwhitney
approved these changes
Aug 3, 2022
Collaborator
trevorwhitney
left a comment
trevorwhitney
left a comment
There was a problem hiding this comment.
lgtm, I'm assuming we will need to update build images as well?
Contributor
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
Contributor
Author
I don't think so - this just allows the project to build against 1.19, but we aren't actually using 1.19 yet |
owen-d
approved these changes
Aug 3, 2022
MasslessParticle
pushed a commit
that referenced
this pull request
Sep 7, 2022
<!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> **What this PR does / why we need it**: Allows for updating to the latest Loki version on OpenBSD after a series of updates in https://github.com/golang/x/sys were committed (and after #6833)
lxwzy
pushed a commit
to lxwzy/loki
that referenced
this pull request
Nov 7, 2022
* Support building against Go 1.19 Fixes grafana#6831 Hat-tip to @rfratto in grafana/agent#1985 Signed-off-by: Danny Kopping <[email protected]> * go mod tidy Signed-off-by: Danny Kopping <[email protected]>
lxwzy
pushed a commit
to lxwzy/loki
that referenced
this pull request
Nov 7, 2022
…7021) <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Name your PR as `<Feature Area>: Describe your change`. a. Do not end the title with punctuation. It will be added in the changelog. b. Start with an imperative verb. Example: Fix the latency between System A and System B. c. Use sentence case, not title case. d. Use a complete phrase or sentence. The PR title will appear in a changelog, so help other people understand what your change will be. 3. Rebase your PR if it gets out of sync with main --> **What this PR does / why we need it**: Allows for updating to the latest Loki version on OpenBSD after a series of updates in https://github.com/golang/x/sys were committed (and after grafana#6833)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6831
Thanks for reporting this @andig 👍
Hat-tip to @rfratto in grafana/agent#1985