feat: Add a metric ingestion time SM sanitization #15222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwanthgoli
reviewed
Dec 3, 2024
| normalized = otlptranslate.NormalizeLabel(structuredMetadata[i].Name) | ||
| if normalized != structuredMetadata[i].Name { | ||
| structuredMetadata[i].Name = normalized | ||
| d.tenantPushSanitizedStructuredMetadata.WithLabelValues(tenantID).Inc() |
There was a problem hiding this comment.
should we also add this for value sanitisation?
There was a problem hiding this comment.
yep, this just got missed in my git add --patch and then I saw the test failing as you posted your comment, pushed the value inc() call
ingestion time. Signed-off-by: Callum Styan <[email protected]>
cstyan
force-pushed
the
callum-sm-sanitize-metric
branch
from
56f2cf7 to
91cabf9
Compare
Signed-off-by: Callum Styan <[email protected]>
cyriltovena
approved these changes
Dec 3, 2024
This was referenced Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a per-tenant metric for when a tenant has structured metadata sanitized at ingestion time. This would be less spammy than a log line, and while the
tenantlabel could be high cardinality it's unlikely to be as the % of users using SM and sending SM that has invalid characters is likely low.Some of the discussion around #15113 has been that the query time sanitization of the SM name and value (value would be sanitized in that PR, name sanitization is already in place) is that query time sanitization is expensive, and we'd like to move that functionality to be on a per-tenant basis.
The goal here is to inform us which users have been sending invalid SM so that we modify the query time SM sanitization code blocks so that they're only run on a per-tenant basis based on per-tenant overrides. With this metric in place we would be able to have a good idea ahead of time of which users have been sending invalid SM before we make the swap over so that we can set the per-tenant config in advance of the rollout.