fix: Use separate variable to track the consume offset #15095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if lastCommittedOffset >= 0 { | ||
| lastCommittedOffset++ // We want to begin to read from the next offset, but only if we've previously committed an offset. | ||
| consumeOffset := kafkaStartOffset | ||
| if lastCommittedOffset > 0 { |
There was a problem hiding this comment.
Owen's PR changed this from > 0 to >= 0. I assume 0 is a valid commit offset (the 0th message), so we should read from 1?
grobinson-grafana
force-pushed
the
grobinson/small-cleanup
branch
from
8ff758c to
ee1f479
Compare
grobinson-grafana
force-pushed
the
grobinson/small-cleanup
branch
from
ee1f479 to
bb99686
Compare
This commit updates reader_service.go to use a separate variable to track the consume offset instead of mutating the last committed offset. I found this makes the code easier to follow as the last committed offset does not change.
grobinson-grafana
force-pushed
the
grobinson/small-cleanup
branch
from
bb99686 to
372aa2a
Compare
This was referenced Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit updates reader_service.go to use a separate variable to track the consume offset instead of mutating the last committed offset. I found this makes the code easier to follow as the last committed offset does not change.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR