Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing flush op timeout #13679

Merged
merged 3 commits into from
Jul 26, 2024
Merged

fix: add missing flush op timeout #13679

merged 3 commits into from
Jul 26, 2024

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Jul 26, 2024 •
edited
Loading

What this PR does / why we need it:

This pull request adds a missing flush op timeout for Ingester RF-1.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana self-assigned this Jul 26, 2024
@grobinson-grafana grobinson-grafana requested a review from a team as a code owner July 26, 2024 14:00
cyriltovena
cyriltovena approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jul 26, 2024
@grobinson-grafana grobinson-grafana merged commit 62c5c5c into main Jul 26, 2024
62 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/add-missing-timeout branch July 26, 2024 14:22
benclive pushed a commit to cyriltovena/loki that referenced this pull request Jul 31, 2024
@grobinson-grafana @benclive
fix: add missing flush op timeout (grafana#13679)
ee9aeb6
This was referenced Aug 15, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 9, 2024
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 23, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees

@grobinson-grafana grobinson-grafana

Labels
size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grobinson-grafana @cyriltovena