Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for liveness and startup probes in loki helm chart #13678

Open
AleksaC opened this issue Jul 26, 2024 · 1 comment
Open

Add support for liveness and startup probes in loki helm chart #13678

AleksaC opened this issue Jul 26, 2024 · 1 comment
Labels
area/helm type/feature Something new we should do

Comments

@AleksaC
Copy link
Contributor

AleksaC commented Jul 26, 2024

The chart currently only supports configuring readiness probes. In addition to that the default value for initialDelaySeconds is set to 30s which is much longer than it takes for most pods to start.

A better approach is to use a startup probe with a short period and bigger failure threshold allowing pods to be marked as ready much faster.

The new probes could be left empty by default to be consistent with the current behavior.

If you accept this feature I might be able to create a PR implementing it.
@JStickler JStickler added type/feature Something new we should do area/helm labels Jul 29, 2024
@lindhe
Copy link
Contributor

lindhe commented Dec 11, 2024

Seems related to #13967

@lindhe lindhe mentioned this issue Dec 11, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/helm type/feature Something new we should do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JStickler @lindhe @AleksaC