feat(detected-labels): remove cardinality filter #13652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svennergr
force-pushed
the
svennergr/remove-detected-labels-cardinality
branch
from
2c4b935
to
f99c5cb
Compare
svennergr
changed the title
trevorwhitney
approved these changes
Jul 24, 2024
| if dl.Cardinality > 1 && dl.Cardinality < 50 { | ||
| result = append(result, &logproto.DetectedLabel{Label: dl.Label, Cardinality: dl.Cardinality}) | ||
| } | ||
| result = append(result, &logproto.DetectedLabel{Label: dl.Label, Cardinality: dl.Cardinality}) |
There was a problem hiding this comment.
I'm fine with this, though if it were a request parameter it would give us more flexibility to find the right balance in the future. But, let's nuke it for now and see if it becomes a problem.
benclive
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jul 31, 2024
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Limiting the cardinality on labels hides a lot of useful information. This PR removes these limits for now.
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR