Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): removed helm test #13651

Merged
merged 5 commits into from
Jul 24, 2024
Merged

fix(helm): removed helm test #13651

merged 5 commits into from
Jul 24, 2024

Conversation

Jayclifford345
Copy link
Contributor

Removed helm test

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Jayclifford345 Jayclifford345 requested a review from a team as a code owner July 24, 2024 16:10
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] Approving so that we can unblock users.

@Jayclifford345
Copy link
Contributor Author

@JStickler does this need a helm version bump? I assume so

@Jayclifford345 Jayclifford345 changed the title fix:removed helm test fix: removed helm test Jul 24, 2024
@JStickler
Copy link
Contributor

@Jayclifford345 Yes, please bump the version.

@Jayclifford345
Copy link
Contributor Author

Version bumped to 6.7.3

@JStickler
Copy link
Contributor

Version needs to be updated in three files.
For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md.

@Jayclifford345 Jayclifford345 changed the title fix: removed helm test fix(helm): removed helm test Jul 24, 2024
@Jayclifford345
Copy link
Contributor Author

Okay think I both of those places updated

.gitignore Outdated Show resolved Hide resolved
@Jayclifford345
Copy link
Contributor Author

@edspace added a new line in gitignore. The tests will run again the integration test took 10 minutes last time :(

@JStickler JStickler merged commit ef03476 into main Jul 24, 2024
63 checks passed
@JStickler JStickler deleted the hotfix-loki-helm-test branch July 24, 2024 17:34
benclive pushed a commit to cyriltovena/loki that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants