feat(rf1): Store index ref in metastore #13613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclive
reviewed
Jul 22, 2024
pkg/storage/wal/ref.go
Outdated
| return DataRef(offset<<32 | size) | ||
| } | ||
|
|
||
| func (b DataRef) Unpack() (int, int) { |
There was a problem hiding this comment.
Whats the reason to pack these values?
There was a problem hiding this comment.
None really, we could use 2 int64 or 2 int32. The code was just available and I copy pasted.
Do you prefer to change it ?
There was a problem hiding this comment.
If we're using it elsewhere then I'm happy to continue using it. If this is the first usage I'm less inclined to introduce this as a way of storing multiple values unless there is a good reason (maybe due to perf, storage concerns etc.)
benclive
approved these changes
Jul 23, 2024
pkg/storage/wal/ref.go
Outdated
| @@ -0,0 +1,13 @@ | |||
| package wal | |||
There was a problem hiding this comment.
this file can be removed now
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This stores in the metastore the offset and size of the index for each WAL segment.
We'll be able to use this to avoid downloading all chunks that we don't need in the future read path.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR