Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a retry middleware to all the stats handlers #13584

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

slim-bean
Copy link
Collaborator

What this PR does / why we need it:

We use retry middleware for all the subquery downstream requests through the scheduler to the querier, but we did not have any retries on our stats calls which also go through the schedulers downstream to the queriers, this leads to a number of 5xx errors on queries which very likely would have been resolved by a simple retry.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@slim-bean slim-bean requested a review from a team as a code owner July 19, 2024 13:45
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 19, 2024
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit 7232795 into main Jul 19, 2024
61 checks passed
@slim-bean slim-bean deleted the retry-stats-queries branch July 19, 2024 18:13
grafanabot pushed a commit that referenced this pull request Jul 19, 2024
Signed-off-by: Edward Welch <[email protected]>
(cherry picked from commit 7232795)
slim-bean added a commit that referenced this pull request Jul 19, 2024
Signed-off-by: Edward Welch <[email protected]>
(cherry picked from commit 7232795)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants