Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove tenant label tagging from profiles to reduce cardinality #13270

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

slim-bean
Copy link
Collaborator

What this PR does / why we need it:

After some discussions with our Pyroscope team, the cardinality of tagging the tenant are causing concerns so we are removing that for now, the real goal of this change was to identify read vs write, not so much tenant.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@slim-bean slim-bean requested a review from a team as a code owner June 20, 2024 11:16
@slim-bean slim-bean merged commit f897758 into main Jun 20, 2024
61 checks passed
@slim-bean slim-bean deleted the remove-tenant-label branch June 20, 2024 12:41
@slim-bean slim-bean added type/bug Somehing is not working as expected backport k207 labels Jun 20, 2024
grafanabot pushed a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k207 size/S type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants