Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix setting of info log level when trying to detect level from log lines #12635

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
I made a mistake while setting log level for info logs with logfmt/json format. This PR fixes it.

@sandeepsukhani sandeepsukhani requested a review from a team as a code owner April 16, 2024 15:37
@sandeepsukhani sandeepsukhani enabled auto-merge (squash) April 16, 2024 15:43
@sandeepsukhani sandeepsukhani merged commit 0831802 into main Apr 16, 2024
12 checks passed
@sandeepsukhani sandeepsukhani deleted the fix-log-level-detection branch April 16, 2024 15:47
@maetolay
Copy link

Please rollout this version soon, this bug affecting our production logs

@tanadeau
Copy link

Could we get a 3.x release with this fix soon?

@kjq
Copy link

kjq commented May 9, 2024

When will the Loki Helm charts be updated? We just updated with Helm v6.5.1 (v3.0.0) and it still shows the wrong log-level (i see it is tagged for a 3.1.x release)

@kjq
Copy link

kjq commented Jun 4, 2024

Is there an ETA on when this will be merged in? It was fixed 3 weeks ago and the latest Loki does not reflect the changes so the image tag version in the Helm charts cannot even be updated.

@Usergitbit
Copy link

Still hasn't been released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants