-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update module google.golang.org/grpc [security] (main) #11031
Merged
kavirajk
merged 1 commit into
main
from
deps-update/main-go-google.golang.org/grpc-vulnerability
Oct 26, 2023
Merged
fix(deps): update module google.golang.org/grpc [security] (main) #11031
kavirajk
merged 1 commit into
main
from
deps-update/main-go-google.golang.org/grpc-vulnerability
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate
bot
added
area/security
dependencies
Pull requests that update a dependency file
labels
Oct 25, 2023
renovate
bot
changed the title
fix(deps): update module google.golang.org/grpc to v1.58.3 [security] (main)
fix(deps): update module google.golang.org/grpc [security] (main)
Oct 25, 2023
renovate
bot
force-pushed
the
deps-update/main-go-google.golang.org/grpc-vulnerability
branch
from
October 25, 2023 22:30
d5845f5
to
cad7a5c
Compare
kavirajk
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
kavirajk
deleted the
deps-update/main-go-google.golang.org/grpc-vulnerability
branch
October 26, 2023 08:30
This was referenced Mar 25, 2024
This was referenced Apr 1, 2024
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…afana#11031) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [google.golang.org/grpc](https://github.com/grpc/grpc-go) | require | minor | `v1.53.0` -> `v1.56.3` | | [google.golang.org/grpc](https://github.com/grpc/grpc-go) | require | patch | `v1.58.2` -> `v1.58.3` | ### GitHub Vulnerability Alerts #### [GHSA-m425-mq94-257g](https://github.com/grpc/grpc-go/security/advisories/GHSA-m425-mq94-257g) ### Impact In affected releases of gRPC-Go, it is possible for an attacker to send HTTP/2 requests, cancel them, and send subsequent requests, which is valid by the HTTP/2 protocol, but would cause the gRPC-Go server to launch more concurrent method handlers than the configured maximum stream limit. ### Patches This vulnerability was addressed by #&grafana#8203;6703 and has been included in patch releases: 1.56.3, 1.57.1, 1.58.3. It is also included in the latest release, 1.59.0. Along with applying the patch, users should also ensure they are using the `grpc.MaxConcurrentStreams` server option to apply a limit to the server's resources used for any single connection. ### Workarounds None. ### References #&grafana#8203;6703 --- ### Release Notes <details> <summary>grpc/grpc-go (google.golang.org/grpc)</summary> ### [`v1.56.3`](https://github.com/grpc/grpc-go/releases/tag/v1.56.3): Release 1.56.3 [Compare Source](https://github.com/grpc/grpc-go/compare/v1.56.2...v1.56.3) ### Security - server: prohibit more than MaxConcurrentStreams handlers from running at once (CVE-2023-44487) In addition to this change, applications should ensure they do not leave running tasks behind related to the RPC before returning from method handlers, or should enforce appropriate limits on any such work. ### [`v1.56.2`](https://github.com/grpc/grpc-go/releases/tag/v1.56.2): Release 1.56.2 [Compare Source](https://github.com/grpc/grpc-go/compare/v1.56.1...v1.56.2) - status: To fix a panic, `status.FromError` now returns an error with `codes.Unknown` when the error implements the `GRPCStatus()` method, and calling `GRPCStatus()` returns `nil`. ([#&grafana#8203;6374](https://github.com/grpc/grpc-go/issues/6374)) ### [`v1.56.1`](https://github.com/grpc/grpc-go/releases/tag/v1.56.1): Release 1.56.1 [Compare Source](https://github.com/grpc/grpc-go/compare/v1.56.0...v1.56.1) - client: handle empty address lists correctly in addrConn.updateAddrs ### [`v1.56.0`](https://github.com/grpc/grpc-go/releases/tag/v1.56.0): Release 1.56.0 [Compare Source](https://github.com/grpc/grpc-go/compare/v1.55.1...v1.56.0) ### New Features - client: support channel idleness using `WithIdleTimeout` dial option ([#&grafana#8203;6263](https://github.com/grpc/grpc-go/issues/6263)) - This feature is currently disabled by default, but will be enabled with a 30 minute default in the future. - client: when using pickfirst, keep channel state in TRANSIENT_FAILURE until it becomes READY ([gRFC A62](https://github.com/grpc/proposal/blob/master/A62-pick-first.md)) ([#&grafana#8203;6306](https://github.com/grpc/grpc-go/issues/6306)) - xds: Add support for Custom LB Policies ([gRFC A52](https://github.com/grpc/proposal/blob/master/A52-xds-custom-lb-policies.md)) ([#&grafana#8203;6224](https://github.com/grpc/grpc-go/issues/6224)) - xds: support pick_first Custom LB policy ([gRFC A62](https://github.com/grpc/proposal/blob/master/A62-pick-first.md)) ([#&grafana#8203;6314](https://github.com/grpc/grpc-go/issues/6314)) ([#&grafana#8203;6317](https://github.com/grpc/grpc-go/issues/6317)) - client: add support for pickfirst address shuffling ([gRFC A62](https://github.com/grpc/proposal/blob/master/A62-pick-first.md)) ([#&grafana#8203;6311](https://github.com/grpc/grpc-go/issues/6311)) - xds: Add support for String Matcher Header Matcher in RDS ([#&grafana#8203;6313](https://github.com/grpc/grpc-go/issues/6313)) - xds/outlierdetection: Add Channelz Logger to Outlier Detection LB ([#&grafana#8203;6145](https://github.com/grpc/grpc-go/issues/6145)) - Special Thanks: [@&grafana#8203;s-matyukevich](https://github.com/s-matyukevich) - xds: enable RLS in xDS by default ([#&grafana#8203;6343](https://github.com/grpc/grpc-go/issues/6343)) - orca: add support for application_utilization field and missing range checks on several metrics setters - balancer/weightedroundrobin: add new LB policy for balancing between backends based on their load reports ([gRFC A58](https://github.com/grpc/proposal/blob/master/A58-client-side-weighted-round-robin-lb-policy.md)) ([#&grafana#8203;6241](https://github.com/grpc/grpc-go/issues/6241)) - authz: add conversion of json to RBAC Audit Logging config ([#&grafana#8203;6192](https://github.com/grpc/grpc-go/issues/6192)) - authz: add support for stdout logger ([#&grafana#8203;6230](https://github.com/grpc/grpc-go/issues/6230) and [#&grafana#8203;6298](https://github.com/grpc/grpc-go/issues/6298)) - authz: support customizable audit functionality for authorization policy ([#&grafana#8203;6192](https://github.com/grpc/grpc-go/issues/6192) [#&grafana#8203;6230](https://github.com/grpc/grpc-go/issues/6230) [#&grafana#8203;6298](https://github.com/grpc/grpc-go/issues/6298) [#&grafana#8203;6158](https://github.com/grpc/grpc-go/issues/6158) [#&grafana#8203;6304](https://github.com/grpc/grpc-go/issues/6304) and [#&grafana#8203;6225](https://github.com/grpc/grpc-go/issues/6225)) ### Bug Fixes - orca: fix a race at startup of out-of-band metric subscriptions that would cause the report interval to request 0 ([#&grafana#8203;6245](https://github.com/grpc/grpc-go/issues/6245)) - xds/xdsresource: Fix Outlier Detection Config Handling and correctly set xDS Defaults ([#&grafana#8203;6361](https://github.com/grpc/grpc-go/issues/6361)) - xds/outlierdetection: Fix Outlier Detection Config Handling by setting defaults in ParseConfig() ([#&grafana#8203;6361](https://github.com/grpc/grpc-go/issues/6361)) ### API Changes - orca: allow a ServerMetricsProvider to be passed to the ORCA service and ServerOption ([#&grafana#8203;6223](https://github.com/grpc/grpc-go/issues/6223)) ### [`v1.55.1`](https://github.com/grpc/grpc-go/releases/tag/v1.55.1): Release 1.55.1 [Compare Source](https://github.com/grpc/grpc-go/compare/v1.55.0...v1.55.1) - status: To fix a panic, `status.FromError` now returns an error with `codes.Unknown` when the error implements the `GRPCStatus()` method, and calling `GRPCStatus()` returns `nil`. ([#&grafana#8203;6374](https://github.com/grpc/grpc-go/issues/6374)) ### [`v1.55.0`](https://github.com/grpc/grpc-go/releases/tag/v1.55.0): Release 1.55.0 [Compare Source](https://github.com/grpc/grpc-go/compare/v1.54.1...v1.55.0) ### Behavior Changes - xds: enable federation support by default ([#&grafana#8203;6151](https://github.com/grpc/grpc-go/issues/6151)) - status: `status.Code` and `status.FromError` handle wrapped errors ([#&grafana#8203;6031](https://github.com/grpc/grpc-go/issues/6031) and [#&grafana#8203;6150](https://github.com/grpc/grpc-go/issues/6150)) - Special Thanks: [@&grafana#8203;psyhatter](https://github.com/psyhatter) ### New Features - xds/xdsclient: support `ignore_resource_deletion` server feature as per gRFC [A53](https://github.com/grpc/proposal/blob/master/A53-xds-ignore-resource-deletion.md) ([#&grafana#8203;6035](https://github.com/grpc/grpc-go/issues/6035)) - security/advancedtls: add min/max TLS version selection options ([#&grafana#8203;6007](https://github.com/grpc/grpc-go/issues/6007)) - Special Thanks: [@&grafana#8203;joeljeske](https://github.com/joeljeske) ### Bug Fixes - xds: stop routing RPCs to deleted clusters ([#&grafana#8203;6125](https://github.com/grpc/grpc-go/issues/6125)) - client: fix race between stream creation and GOAWAY receipt, which could lead to spurious UNAVAILABLE stream errors ([#&grafana#8203;6142](https://github.com/grpc/grpc-go/issues/6142)) ### Performance Improvements - server: improve stream handler goroutine worker allocation when [`NumStreamWorkers`](https://pkg.go.dev/google.golang.org/grpc#NumStreamWorkers) is used ([#&grafana#8203;6004](https://github.com/grpc/grpc-go/issues/6004)) - Special Thanks: [@&grafana#8203;SaveTheRbtz](https://github.com/SaveTheRbtz) ### [`v1.54.1`](https://github.com/grpc/grpc-go/releases/tag/v1.54.1): Release 1.54.1 [Compare Source](https://github.com/grpc/grpc-go/compare/v1.54.0...v1.54.1) ### Bug Fixes - credentials/alts: revert a change that causes a crash in the handshaker ### [`v1.54.0`](https://github.com/grpc/grpc-go/releases/tag/v1.54.0): Release 1.54.0 [Compare Source](https://github.com/grpc/grpc-go/compare/v1.53.0...v1.54.0) ### Behavior Changes - xds: remove support for xDS v2 transport API ([#&grafana#8203;6013](https://github.com/grpc/grpc-go/issues/6013)) ### New Features - server: expose `SetSendCompressor` API to set send compressor name ([#&grafana#8203;5744](https://github.com/grpc/grpc-go/issues/5744)) - Special Thanks: [@&grafana#8203;jronak](https://github.com/jronak) - xdsclient: include `Node` proto only in the first discovery request message, to improve performance ([#&grafana#8203;6078](https://github.com/grpc/grpc-go/issues/6078)) ### Bug Fixes - metadata: fix validation logic and properly validate metadata appended via `AppendToOutgoingContext` ([#&grafana#8203;6001](https://github.com/grpc/grpc-go/issues/6001)) - Special Thanks: [@&grafana#8203;ktalg](https://github.com/ktalg) - transport: do not close connections when we encounter I/O errors until after all data is consumed ([#&grafana#8203;6110](https://github.com/grpc/grpc-go/issues/6110)) - ringhash: ensure addresses are consistently hashed across updates ([#&grafana#8203;6066](https://github.com/grpc/grpc-go/issues/6066)) - xds/clusterimpl: fix a bug causing unnecessary closing and re-opening of LRS streams ([#&grafana#8203;6112](https://github.com/grpc/grpc-go/issues/6112)) - xds: NACK route configuration if sum of weights of weighted clusters exceeds uint32\_max ([#&grafana#8203;6085](https://github.com/grpc/grpc-go/issues/6085)) ### Documentation - resolver: update `Resolver.Scheme()` docstring to mention requirement of lowercase scheme names ([#&grafana#8203;6014](https://github.com/grpc/grpc-go/issues/6014)) - resolver: document expected error handling of `UpdateState` errors ([#&grafana#8203;6002](https://github.com/grpc/grpc-go/issues/6002)) - Special Thanks: [@&grafana#8203;fho](https://github.com/fho) - examples: add example for ORCA load reporting ([#&grafana#8203;6114](https://github.com/grpc/grpc-go/issues/6114)) - examples: add an example to illustrate authorization (authz) support ([#&grafana#8203;5920](https://github.com/grpc/grpc-go/issues/5920)) - Special Thanks: [@&grafana#8203;KenxinKun](https://github.com/KenxinKun) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/grafana/loki). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v1.53.0
->v1.56.3
v1.58.2
->v1.58.3
GitHub Vulnerability Alerts
GHSA-m425-mq94-257g
Impact
In affected releases of gRPC-Go, it is possible for an attacker to send HTTP/2 requests, cancel them, and send subsequent requests, which is valid by the HTTP/2 protocol, but would cause the gRPC-Go server to launch more concurrent method handlers than the configured maximum stream limit.
Patches
This vulnerability was addressed by #6703 and has been included in patch releases: 1.56.3, 1.57.1, 1.58.3. It is also included in the latest release, 1.59.0.
Along with applying the patch, users should also ensure they are using the
grpc.MaxConcurrentStreams
server option to apply a limit to the server's resources used for any single connection.Workarounds
None.
References
#6703
Release Notes
grpc/grpc-go (google.golang.org/grpc)
v1.56.3
: Release 1.56.3Compare Source
Security
server: prohibit more than MaxConcurrentStreams handlers from running at once (CVE-2023-44487)
In addition to this change, applications should ensure they do not leave running tasks behind related to the RPC before returning from method handlers, or should enforce appropriate limits on any such work.
v1.56.2
: Release 1.56.2Compare Source
status.FromError
now returns an error withcodes.Unknown
when the error implements theGRPCStatus()
method, and callingGRPCStatus()
returnsnil
. (#6374)v1.56.1
: Release 1.56.1Compare Source
v1.56.0
: Release 1.56.0Compare Source
New Features
WithIdleTimeout
dial option (#6263)Bug Fixes
API Changes
v1.55.1
: Release 1.55.1Compare Source
status.FromError
now returns an error withcodes.Unknown
when the error implements theGRPCStatus()
method, and callingGRPCStatus()
returnsnil
. (#6374)v1.55.0
: Release 1.55.0Compare Source
Behavior Changes
status.Code
andstatus.FromError
handle wrapped errors (#6031 and #6150)New Features
ignore_resource_deletion
server feature as per gRFC A53 (#6035)Bug Fixes
Performance Improvements
NumStreamWorkers
is used (#6004)v1.54.1
: Release 1.54.1Compare Source
Bug Fixes
v1.54.0
: Release 1.54.0Compare Source
Behavior Changes
New Features
SetSendCompressor
API to set send compressor name (#5744)Node
proto only in the first discovery request message, to improve performance (#6078)Bug Fixes
AppendToOutgoingContext
(#6001)Documentation
Resolver.Scheme()
docstring to mention requirement of lowercase scheme names (#6014)UpdateState
errors (#6002)Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate. View repository job log here.