Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the check failure/success in the corresponding page span #4205

Open
ankur22 opened this issue Jan 21, 2025 · 0 comments
Open

Add the check failure/success in the corresponding page span #4205

ankur22 opened this issue Jan 21, 2025 · 0 comments

Comments

@ankur22
Copy link
Contributor

ankur22 commented Jan 21, 2025

Feature Description

When the user uses a check (or soon to be released assert) we want to be able to instrument the relevant APIs with traces. This will allow us to do two things:

  1. add the success/failure result in the API call trace, similar to how we add error details to current traces.
  2. and add it to the corresponding page span to allow allow us to view the holistic view of the iteration in the timeline using the traces.

Suggested Solution (optional)

No response

Already existing or connected issues / PRs (optional)

No response

@ankur22 ankur22 changed the title Add a check failure/success in the corresponding page span Add the check failure/success in the corresponding page span Jan 21, 2025
@inancgumus inancgumus added triage and removed triage labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants