Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TracingInstrumentation breaks fetch requests #79

Closed
bfmatei opened this issue Dec 13, 2022 · 2 comments · Fixed by #156
Closed

TracingInstrumentation breaks fetch requests #79

bfmatei opened this issue Dec 13, 2022 · 2 comments · Fixed by #156
Labels
bug Report a bug

Comments

@bfmatei
Copy link
Collaborator

bfmatei commented Dec 13, 2022

Description

When using TracingInstrumentation, fetch requests with relative URLs are broken in sub-pages.

Steps to reproduce

  1. Add Faro Web SDK and TracingIntrumentation to the project
  2. Add a fetch request with a relative URL
  3. Navigate to a sub-page
  4. Observe the fetch request

Expected behavior

The request will be executed without any issue.

Actual behavior

The request has a tampered URL relative to the sub-page.

Environment

  • SDK version: 1.0.0-beta3
  • SDK instrumentations: Web SDK, Web Tracing
  • Device type: all
  • Device name: all
  • OS: all
  • Browser: all
@bfmatei bfmatei added the bug Report a bug label Dec 13, 2022
@bfmatei bfmatei self-assigned this Dec 13, 2022
@bfmatei bfmatei removed their assignment Dec 21, 2022
@domasx2
Copy link
Collaborator

domasx2 commented Mar 22, 2023

Fixed in opentelemetry.js via open-telemetry/opentelemetry-js#3670 and released wih 1.11.0

@domasx2 domasx2 closed this as completed Mar 22, 2023
@domasx2 domasx2 reopened this Mar 22, 2023
@domasx2
Copy link
Collaborator

domasx2 commented Mar 22, 2023

web-tracing needs to pull newer version of otel

@codecapitano codecapitano mentioned this issue Apr 13, 2023
Merged
3 tasks
@codecapitano codecapitano linked a pull request Apr 13, 2023 that will close this issue
79 tracinginstrumentation breaks fetch requests #156
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Report a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

79 tracinginstrumentation breaks fetch requests grafana/faro-web-sdk
2 participants
@domasx2 @bfmatei