Customizable ring HTTP status page handler #166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't want to give http handler the access to perform random CAS on the rings, especially since I want to export the http handler and that would mean that I need to export CasRing(), and that's something I want to avoid. Signed-off-by: Oleg Zaytsev <[email protected]>
Since this operation returns a Desc, IMO that's a better name. Signed-off-by: Oleg Zaytsev <[email protected]>
Signed-off-by: Oleg Zaytsev <[email protected]>
Signed-off-by: Oleg Zaytsev <[email protected]>
I don't want to start the file with that, since it's not something needed for users coming to see how to use this. Signed-off-by: Oleg Zaytsev <[email protected]>
It also allows configuring the template used to be rendered. Signed-off-by: Oleg Zaytsev <[email protected]>
colega
force-pushed
the
customizable-ring-http-handler
branch
from
b67e611 to
69bc4ee
Compare
Signed-off-by: Oleg Zaytsev <[email protected]>
Instead of asking for the timeout when instantiating the http status handler, move the logic of determining that to the rings implemeantion. This makes it easier to instantiate in downstream projects (we don't need to lookup the config). Signed-off-by: Oleg Zaytsev <[email protected]>
Contributor
Author
|
(I moved this to draft as I want to make sure first that it's usable in Mimir, I found some issues using it in the services where the ring isn't initialised until service has started) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Exports the ring HTTP status page handler, allowing to pass in a custom template similarly to what I did in #163 for memberlist.
I strongly recommend checking the commits (and their descriptions) individually to make the review easier.
Which issue(s) this PR fixes:
None
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]