check if OTEL_EXPORTER_* variables are both set AND not empty#426
Closed
milohansen wants to merge 4 commits into
Closed
check if OTEL_EXPORTER_* variables are both set AND not empty#426milohansen wants to merge 4 commits into
milohansen wants to merge 4 commits into
Conversation
|
|
zeitlinger
approved these changes
Apr 22, 2025
Member
|
thanks for the contribution! |
auto-merge was automatically disabled
April 22, 2025 17:19
Head branch was pushed to by a user without write access
Contributor
Author
|
Code is updated and passes the lint check now. |
Member
|
closed in favor of #434 |
auto-merge was automatically disabled
April 23, 2025 12:25
Pull request was closed
Member
|
turned out that you also have to check if the variable exists, because of docker-otel-lgtm/docker/logging.sh Line 3 in 4beb095 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
docker/run-otelcol.shto check if the OTEL_EXPORTER_* environment variables are both present and not empty.Fixes #421