Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Commit 9346bed

Browse files
authored
Merge pull request #191 from gouthamve/change-flags
Rename changed flags for 1.4 release.
2 parents e211800 + f07acd3 commit 9346bed

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
* [CHANGE] We now allow queries that are 32 days long. For example, rate(metric[32d]). Before it was 31d. #173
1010
* [CHANGE] Renamed `container_name` and `pod_name` label names to `container` and `pod` respectively. This is required in order to comply with cAdvisor metrics changes shipped with Kubernetes 1.16. #179
1111
* [CHANGE] Removed the `experimental` prefix from blocks storage CLI flags. #179
12+
* [CHANGE] Rename flags `store-gateway.replication-factor` and `store-gateway.tokens-file-path` to `store-gateway.sharding-ring.replication-factor` and `store-gateway.sharding-ring.tokens-file-path` in anticipation of v1.4 release. #191
1213
* [ENHANCEMENT] Enable support for HA in the Cortex Alertmanager #147
1314
* [ENHANCEMENT] Support `alertmanager.fallback_config` option in the Alertmanager. #179
1415
* [ENHANCEMENT] Add support for S3 block storage. #181

cortex/config.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@
159159
'store-gateway.sharding-ring.store': 'consul',
160160
'store-gateway.sharding-ring.consul.hostname': 'consul.%s.svc.cluster.local:8500' % $._config.namespace,
161161
'store-gateway.sharding-ring.prefix': '',
162-
'store-gateway.replication-factor': $._config.store_gateway_replication_factor,
162+
'store-gateway.sharding-ring.replication-factor': $._config.store_gateway_replication_factor,
163163
},
164164
gcsBlocksStorageConfig:: $._config.genericBlocksStorageConfig {
165165
'blocks-storage.backend': 'gcs',

cortex/tsdb.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@
176176

177177
// Persist ring tokens so that when the store-gateway will be restarted
178178
// it will pick the same tokens
179-
'store-gateway.tokens-file-path': '/data/tokens',
179+
'store-gateway.sharding-ring.tokens-file-path': '/data/tokens',
180180
} + $.blocks_chunks_caching_config + $.blocks_metadata_caching_config,
181181

182182
store_gateway_ports:: $.util.defaultPorts,

0 commit comments

Comments
 (0)