-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release v0.8.0 #200
Conversation
WalkthroughThis pull request focuses on updating the versioning scheme for the Augurs workspace. The workspace package version has been incremented from Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (4)
Cargo.toml
(2 hunks)crates/augurs-forecaster/CHANGELOG.md
(1 hunks)crates/augurs-outlier/CHANGELOG.md
(1 hunks)crates/augurs-prophet/CHANGELOG.md
(1 hunks)
β Files skipped from review due to trivial changes (1)
- crates/augurs-outlier/CHANGELOG.md
π Additional comments (3)
crates/augurs-forecaster/CHANGELOG.md (1)
9-22
: LGTM on changelog structure and content
The changelog follows the Keep a Changelog format correctly and includes proper categorization of changes with links to relevant PRs.
Cargo.toml (1)
21-21
: LGTM on version updates
The version updates are consistent across the workspace and all augurs-* dependencies, properly aligned with the 0.8.0 release.
Also applies to: 32-41
crates/augurs-prophet/CHANGELOG.md (1)
10-22
: LGTM on changelog updates
The changelog is well-structured with proper categorization of changes and clear documentation of dependency updates.
|
||
### Fixed | ||
|
||
- make Transform enum non-exhaustive (#194) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking change needs more visibility
The Transform enum being marked as non-exhaustive (#194) is a breaking change that requires pattern matching outside the crate to include a wildcard pattern. This should be moved to a "Breaking Changes" section for better visibility.
### Fixed
- make Transform enum non-exhaustive (#194)
+### Breaking Changes
+
+- make Transform enum non-exhaustive (#194) - Pattern matching on Transform enum outside the crate must now include a wildcard pattern
π Committable suggestion
βΌοΈ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- make Transform enum non-exhaustive (#194) | |
### Fixed | |
### Breaking Changes | |
- make Transform enum non-exhaustive (#194) - Pattern matching on Transform enum outside the crate must now include a wildcard pattern |
8a020d9
to
584cade
Compare
584cade
to
4859bdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π§Ή Nitpick comments (1)
crates/augurs-core/CHANGELOG.md (1)
9-10
: Version entry is consistent with main packageThe version number, date, and comparison link format are consistent with the main package changelog. However, the same date verification comment applies here.
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (6)
Cargo.toml
(2 hunks)crates/augurs-core/CHANGELOG.md
(1 hunks)crates/augurs-forecaster/CHANGELOG.md
(1 hunks)crates/augurs-outlier/CHANGELOG.md
(1 hunks)crates/augurs-prophet/CHANGELOG.md
(1 hunks)crates/augurs/CHANGELOG.md
(1 hunks)
π§ Files skipped from review as they are similar to previous changes (4)
- crates/augurs-outlier/CHANGELOG.md
- crates/augurs-forecaster/CHANGELOG.md
- crates/augurs-prophet/CHANGELOG.md
- Cargo.toml
π Additional comments (3)
crates/augurs/CHANGELOG.md (2)
14-14
: Breaking change is well documented
The breaking change for switching transform
to a trait is properly marked and referenced (PR #213). This aligns with the PR objectives and is consistently documented across packages.
10-11
: Verify the release date
The changelog entry is dated December 23, 2024, which is in the future. Consider either:
- Updating to the actual release date when merging
- Using the placeholder
[Unreleased]
section until the actual release
β Verification successful
Let me verify if there are any established patterns for release dates in the changelog by checking the existing entries.
Future date in changelog entry needs to be moved to [Unreleased]
The changelog already has an [Unreleased] section, and looking at the previous entries (0.6.0 from Nov 8, 0.5.2 from Oct 25, etc.), all release dates are in the past. The current entry for 0.8.0 should be moved under [Unreleased] until the actual release date.
- Move the 0.8.0 changes to the [Unreleased] section
- Remove the future date (2024-12-23)
- Add the actual release date only when the release is made
π Scripts executed
The following scripts were executed for the analysis:
Error: No shell scripts found
Script:
#!/bin/bash
# Check the content of CHANGELOG.md to analyze date patterns
cat crates/augurs/CHANGELOG.md
Length of output: 1974
crates/augurs-core/CHANGELOG.md (1)
13-13
: Breaking change documentation is consistent
The breaking change for the transform trait is documented identically across packages, maintaining consistency in the release notes.
π€ New release
augurs
: 0.7.0 -> 0.8.0 (β API compatible changes)augurs-changepoint
: 0.7.0 -> 0.8.0augurs-core
: 0.7.0 -> 0.8.0 (augurs-clustering
: 0.7.0 -> 0.8.0augurs-dtw
: 0.7.0 -> 0.8.0augurs-ets
: 0.7.0 -> 0.8.0augurs-mstl
: 0.7.0 -> 0.8.0augurs-forecaster
: 0.7.0 -> 0.8.0 (augurs-outlier
: 0.7.0 -> 0.8.0 (β API compatible changes)augurs-prophet
: 0.7.0 -> 0.8.0 (β API compatible changes)augurs-seasons
: 0.7.0 -> 0.8.0augurs-core
breaking changesaugurs-forecaster
breaking changesChangelog
augurs
augurs-changepoint
augurs-core
augurs-clustering
augurs-dtw
augurs-ets
augurs-mstl
augurs-forecaster
augurs-outlier
augurs-prophet
augurs-seasons
This PR was generated with release-plz.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores