diff --git a/CHANGELOG.md b/CHANGELOG.md index 697e429b7fc..8af2963346b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ Main (unreleased) ### Features - A new `mimir.alerts.kubernetes` component which discovers `AlertmanagerConfig` Kubernetes resources and loads them into a Mimir instance. (@ptodev) +- Mark `stage.windowsevent` block in the `loki.process` component as GA. (@kgeckhart) ### Enhancements diff --git a/internal/component/loki/process/stages/stage.go b/internal/component/loki/process/stages/stage.go index 392e6bf5fd1..fde9eef3e4d 100644 --- a/internal/component/loki/process/stages/stage.go +++ b/internal/component/loki/process/stages/stage.go @@ -50,11 +50,6 @@ const ( StageTypeWindowsEvent = "windowsevent" ) -// Add stages that are not GA. Stages that are not specified here are considered GA. -var stagesUnstable = map[string]featuregate.Stability{ - StageTypeWindowsEvent: featuregate.StabilityExperimental, -} - // Processor takes an existing set of labels, timestamp and log entry and returns either a possibly mutated // timestamp and log entry type Processor interface { @@ -121,14 +116,6 @@ func toStage(p Processor) Stage { } } -func checkFeatureStability(stageName string, minStability featuregate.Stability) error { - blockStability, exist := stagesUnstable[stageName] - if exist { - return featuregate.CheckAllowed(blockStability, minStability, fmt.Sprintf("stage %q", stageName)) - } - return nil -} - // New creates a new stage for the given type and configuration. func New(logger log.Logger, jobName *string, cfg StageConfig, registerer prometheus.Registerer, minStability featuregate.Stability) (Stage, error) { var ( @@ -278,10 +265,6 @@ func New(logger log.Logger, jobName *string, cfg StageConfig, registerer prometh panic(fmt.Sprintf("unreachable; should have decoded into one of the StageConfig fields: %+v", cfg)) } - if err := checkFeatureStability(s.Name(), minStability); err != nil { - return nil, err - } - return s, nil } diff --git a/internal/component/loki/process/stages/windowsevent_test.go b/internal/component/loki/process/stages/windowsevent_test.go index 1161da8e7f4..21b6329dc39 100644 --- a/internal/component/loki/process/stages/windowsevent_test.go +++ b/internal/component/loki/process/stages/windowsevent_test.go @@ -228,8 +228,3 @@ func TestWindowsEventValidate(t *testing.T) { }) } } - -func TestWindowsEventStabilityLevel(t *testing.T) { - _, err := NewPipeline(log.NewNopLogger(), loadConfig(testWindowsEventMsgDefaults), nil, prometheus.DefaultRegisterer, featuregate.StabilityPublicPreview) - require.ErrorContains(t, err, `invalid stage config stage "windowsevent" is at stability level "experimental", which is below the minimum allowed stability level "public-preview". Use --stability.level command-line flag to enable "experimental" features`) -}