Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart should restart the controller on configmap change #1530

Closed
MrLuje opened this issue Aug 23, 2024 · 2 comments
Closed

Helm chart should restart the controller on configmap change #1530

MrLuje opened this issue Aug 23, 2024 · 2 comments
Labels
enhancement New feature or request frozen-due-to-age

Comments

@MrLuje
Copy link

MrLuje commented Aug 23, 2024

Request

With an existing/deployed Alloy instance, when updating the configmap the controller should restart on the next upgrade to take the modification into account.
This is usually done by adding an annotation to the controller pod :

annotations:
  checksum/cm: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum | quote }}

Use case

Right now, we have to manually restart the controller (deployment in our case) after updating the configmap

@MrLuje MrLuje added the enhancement New feature or request label Aug 23, 2024
@jkroepke
Copy link
Contributor

You can set configReloader.enabled=true, then alloy do a soft-reload without require a full restart.

@MrLuje
Copy link
Author

MrLuje commented Aug 26, 2024

You can set configReloader.enabled=true, then alloy do a soft-reload without require a full restart.

Oh, perfect ! I missed it in the README
Sorry about that and thanks

@MrLuje MrLuje closed this as completed Aug 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request frozen-due-to-age
Projects
None yet
Development

No branches or pull requests

2 participants