From 111db7f48d6163cb914233a578a0e6db6ec050d5 Mon Sep 17 00:00:00 2001 From: Robert Fratto Date: Wed, 2 Mar 2022 18:10:38 -0500 Subject: [PATCH 1/3] increase swap space on windows for running tests --- .github/workflows/test.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b3c2c598de6b..5b1a72ade0f3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,6 +8,15 @@ jobs: platform: [macos-latest, windows-2019] runs-on: ${{ matrix.platform }} steps: + - name: Increase pagefile + uses: al-cheb/configure-pagefile-action@v1.2 + # Tests on Windows can use a lot of memory, and we need to increase the + # pagefile to compensate. + with: + minimum-size: 16GB + maximum-size: 16GB + disk-root: "C:" + if: ${{ matrix.platform == 'windows-2019' }} - name: Set up Go 1.17 uses: actions/setup-go@v1 with: From 0284ccaceddb0fe2677baa917cf47f89c9c1d4de Mon Sep 17 00:00:00 2001 From: Robert Fratto Date: Wed, 2 Mar 2022 18:22:37 -0500 Subject: [PATCH 2/3] Try windows-latest windows-latest had memory issues more consistently than windows-2019; if this fix works for windows-latest too it's a good sign. --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5b1a72ade0f3..0807fd22ae78 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -5,7 +5,7 @@ jobs: name: Test strategy: matrix: - platform: [macos-latest, windows-2019] + platform: [macos-latest, windows-latest] runs-on: ${{ matrix.platform }} steps: - name: Increase pagefile @@ -16,7 +16,7 @@ jobs: minimum-size: 16GB maximum-size: 16GB disk-root: "C:" - if: ${{ matrix.platform == 'windows-2019' }} + if: ${{ matrix.platform == 'windows-latest' }} - name: Set up Go 1.17 uses: actions/setup-go@v1 with: From b597fe9d0877552f8ce77bad94707d1d1cceacab Mon Sep 17 00:00:00 2001 From: Robert Fratto Date: Wed, 2 Mar 2022 18:39:29 -0500 Subject: [PATCH 3/3] Fix ignored tags in bump-formula-pr It's invalid to list both tags and ignore-tags, and you have to use the ! syntax to ignore a set of tags instead. --- .github/workflows/bump-formula-pr.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/bump-formula-pr.yml b/.github/workflows/bump-formula-pr.yml index 637f10128e1e..160f713f4f61 100644 --- a/.github/workflows/bump-formula-pr.yml +++ b/.github/workflows/bump-formula-pr.yml @@ -5,9 +5,7 @@ on: push: tags: - 'v*' - tags-ignore: - # Ignore release candidates - - 'v*-rc.*' + - '!v*-rc.*' # Ignore release candidates jobs: homebrew-core: name: homebrew-core