Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning 'Space-assignment syntax in Groovy DSL has been deprecated' in 'github-dependency-graph-gradle-plugin-apply' [dependency submission] #541

Closed
cloudshiftchris opened this issue Jan 30, 2025 · 1 comment · Fixed by #542
Labels
bug Something isn't working
Milestone

Comments

@cloudshiftchris
Copy link

When using the dependency submission Gradle action (v4.2.2, with Gradle 8.12.1) the below deprecation warning is observed:

Script '/home/runner/.gradle/init.d/gradle-actions.github-dependency-graph-gradle-plugin-apply.groovy': line 18
Space-assignment syntax in Groovy DSL has been deprecated. This is scheduled to be removed in Gradle 10.0. Use assignment ('username = <value>') instead. Consult the upgrading guide for further information: https://docs.gradle.org/8.12/userguide/upgrading_version_8.html#groovy_space_assignment_syntax
	at gradle_actions_github_dependen_6tsbd0rrkm2rw7c0ku7n1h9i0.run(/home/runner/.gradle/init.d/gradle-actions.github-dependency-graph.init.gradle:33)
	(Run with --stacktrace to get the full stack trace of this deprecation warning.)
Script '/home/runner/.gradle/init.d/gradle-actions.github-dependency-graph-gradle-plugin-apply.groovy': line 19
Space-assignment syntax in Groovy DSL has been deprecated. This is scheduled to be removed in Gradle 10.0. Use assignment ('password = <value>') instead. Consult the upgrading guide for further information: https://docs.gradle.org/8.12/userguide/upgrading_version_8.html#groovy_space_assignment_syntax
	at gradle_actions_github_dependen_6tsbd0rrkm2rw7c0ku7n1h9i0.run(/home/runner/.gradle/init.d/gradle-actions.github-dependency-graph.init.gradle:33)
	(Run with --stacktrace to get the full stack trace of this deprecation warning.)

Note this is used with private repositories w/ authentication via:

        echo "GRADLE_PLUGIN_REPOSITORY_URL=***/maven/gradle-plugin-release/" >> "$GITHUB_ENV"
        echo "GRADLE_PLUGIN_REPOSITORY_USERNAME=aws" >> "$GITHUB_ENV"
        echo "GRADLE_PLUGIN_REPOSITORY_PASSWORD=***" >> "$GITHUB_ENV"

The reference code doesn't appear to use space assignment directly, however.

@bigdaz
Copy link
Member

bigdaz commented Jan 30, 2025

Thanks. It looks like the script is calling a method with username(pluginRepositoryUsername), but 'username' is actually a property with setters and getters.

So I suppose the now-correct call would be username = pluginRepositoryUsername or setUsername(pluginRepositoryUsername).

@bigdaz bigdaz added the bug Something isn't working label Jan 30, 2025
@bigdaz bigdaz added this to the v4.3.0 milestone Jan 30, 2025
@bigdaz bigdaz closed this as completed in 94baf22 Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants