Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queuing related guides contain outdated information about concurrency_count #9977

Open
1 task done
the-eddie opened this issue Nov 17, 2024 · 3 comments · May be fixed by #10026
Open
1 task done

Queuing related guides contain outdated information about concurrency_count #9977

the-eddie opened this issue Nov 17, 2024 · 3 comments · May be fixed by #10026
Labels
docs/website Related to documentation or website good first issue Good for newcomers

Comments

@the-eddie
Copy link

the-eddie commented Nov 17, 2024

Describe the bug

These guides related to queuing still refer to concurrency_count:

However, as confirmed in #9463:

The concurrency_count parameter has been removed from .queue(). In Gradio 4, this parameter was already deprecated and had no effect. In Gradio 5, this parameter has been removed altogether.

Running the code from Queuing guide results in the error below:

Exception has occurred: TypeError
EventListener._setup.<locals>.event_trigger() got an unexpected keyword argument 'concurrency_count'
  File "./test_gradio.py", line 23, in <module>
    greet_btn.click(fn=greet, inputs=[tag, output], outputs=[
TypeError: EventListener._setup.<locals>.event_trigger() got an unexpected keyword argument 'concurrency_count'

Have you searched existing issues? 🔎

  • I have searched and found no existing issues

Reproduction

# Sample code from https://www.gradio.app/guides/queuing

import gradio as gr

with gr.Blocks() as demo:
    prompt = gr.Textbox()
    image = gr.Image()
    generate_btn = gr.Button("Generate Image")
    generate_btn.click(image_gen, prompt, image, concurrency_count=5)

Screenshot

No response

Logs

No response

System Info

Gradio Environment Information:
------------------------------
Operating System: Darwin
gradio version: 5.6.0
gradio_client version: 1.4.3

Severity

I can work around it

@the-eddie the-eddie added the bug Something isn't working label Nov 17, 2024
@abidlabs abidlabs added docs/website Related to documentation or website and removed bug Something isn't working labels Nov 18, 2024
@freddyaboulton
Copy link
Collaborator

Please feel free to submit a PR @the-eddie !

@freddyaboulton freddyaboulton added the good first issue Good for newcomers label Nov 19, 2024
@yinsumirage
Copy link
Contributor

I've figured out what the problem is and reproduced, but I'd like to confirm that the work needed is to remove that part of the documentation about concurrency_count, right? There is no need for additional deletion instructions. I'll swap out the code use case for a working use case. @freddyaboulton

@yinsumirage
Copy link
Contributor

I've also noticed that concurrency_limit parameter isn't mentioned in the documentation, what do you think about adding it to the documentation? @freddyaboulton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/website Related to documentation or website good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants