Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradio demos do not work properly on landing page #1958

Closed
1 task done
abidlabs opened this issue Aug 5, 2022 · 5 comments
Closed
1 task done

Gradio demos do not work properly on landing page #1958

abidlabs opened this issue Aug 5, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@abidlabs
Copy link
Member

abidlabs commented Aug 5, 2022

Describe the bug

I'm seeing issues with the Gradio demos on the website (might be related to the recent PR: #1899):

  • There is no "processing" message to indicate that the demo is running when you click submit (or draw on the sketchpad)
  • The sketchpad does not work after you switch back to it after viewing another demo
  • The echocardiogram one works, but I think it would be better if caching was disabled
  • The speech verification one does not work at all

@aliabd we should revert the changes in this PR, or find a way to fix soon since this is not a good first impression for gradio users that all of our demos are broken on the landing page!

Is there an existing issue for this?

  • I have searched the existing issues

Reproduction

Just visit www.gradio.app

Screenshot

No response

Logs

I'm seeing some stuff in the console that might be applicable. For example:

index.9d04c032.js:970 
        
       Uncaught DOMException: Failed to execute 'drawImage' on 'CanvasRenderingContext2D': The image argument is a canvas element with a width or height of 0.
    at saveLine (https://gradio.s3-us-west-2.amazonaws.com/3.1.1/assets/index.9d04c032.js:970:15)
    at https://gradio.s3-us-west-2.amazonaws.com/3.1.1/assets/index.9d04c032.js:790:4
    at Array.forEach (<anonymous>)
    at draw_lines (https://gradio.s3-us-west-2.amazonaws.com/3.1.1/assets/index.9d04c032.js:776:9)
    at load_save_data (https://gradio.s3-us-west-2.amazonaws.com/3.1.1/assets/index.9d04c032.js:760:4)
    at handle_canvas_resize (https://gradio.s3-us-west-2.amazonaws.com/3.1.1/assets/index.9d04c032.js:844:3)
    at ResizeObserver.<anonymous> (https://gradio.s3-us-west-2.amazonaws.com/3.1.1/assets/index.9d04c032.js:701:5)

System Info

Using Microsoft Edge browser on Windows

Severity

serious, but I can work around it

@abidlabs abidlabs added the bug Something isn't working label Aug 5, 2022
@abidlabs abidlabs changed the title Gradio demos do not work properly on website Gradio demos do not work properly on landing page Aug 5, 2022
@aliabd
Copy link
Collaborator

aliabd commented Aug 5, 2022

Thanks for listing these @abidlabs

I don't think we should revert #1899 because there were usability issues with the iframes too, especially with sizing and the pictionary demo

@abidlabs
Copy link
Member Author

abidlabs commented Aug 5, 2022

Thanks @aliabd for creating the individual issues!

We can close this issue once #1963 is in.

@freddyaboulton
Copy link
Collaborator

Since #1963 got merged we can close @abidlabs @aliabd ?

@abidlabs
Copy link
Member Author

Yes thank you! Let's close this issue, but also do a pypi release soon so that we can get the audio space working again

@abidlabs
Copy link
Member Author

Lol just saw your comment here: #1962 (comment)

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants