Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused useIsomorphicLayoutEffect module #2077

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

pwolfert
Copy link
Contributor

@pwolfert pwolfert commented Mar 26, 2024

Description

I found this during my research for #2076. Seems to have been accidentally included in f3327c9 because the final version of that commit has two copies of that hook. This module appears to be unused and not exported from the package.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Before submitting your pull request, please make sure the following is done:

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have followed the coding guidelines in this project
  • I have tested my changes on different browsers and screen sizes

Seems to have been accidentally included in gpbl@f3327c9 as part of the development process because the final version of that commit has two copies of that hook.
@gpbl gpbl changed the title Delete an unused module chore: remove unused useIsomorphicLayoutEffect module Apr 16, 2024
@gpbl gpbl merged commit eafe0b2 into gpbl:main Apr 16, 2024
11 of 13 checks passed
@gpbl
Copy link
Owner

gpbl commented Apr 16, 2024

Thanks @pwolfert !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants