You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the new jsx transform was introduced, a copy of the JSX runtime started getting included in the index.esm.js bundle. Including this copy meant that we could no longer swap out that module when building our own downstream Preact project. In effect, it broke Preact support.
To fix this, I've updated the rollup config to treat react/jsx-runtime as an external dependency. By externalizing the JSX runtime in this project, it 1) reduces the library bundle size by 32% and 2) allows downstream projects to use whatever JSX runtime they want.
Type of Change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Could possibly be considered a breaking change, but I don't know the landscape of dependent projects well enough to know if that's true.
Checklist
Before submitting your pull request, please make sure the following is done:
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)
I have followed the coding guidelines in this project
I have tested my changes on different browsers and screen sizes
Linked Issues
If this PR addresses any existing issues, please link them here. Example: Fixes #123
Test Plan
You can test that it removes the runtime by searching for the jsxDEV function in dist/index.esm.js before and after the change. You can also see that the file size changed from 144KB to 97KB.
I can also create a branch in my downstream project for testing upon request.
FYI this is also the correct fix if only react/jsx-runtime would exist. Otherwise library consumers would need to use the React version that was used when publishing this library. Either you declare React as a peer dependency, or inline all its packages. Externalizing some entrypoints while declaring others as peer dependencies only worked incidentally.
@eps1lon, maybe I'm not understanding, but it looks like reactis a peer dependency of this library, which should mean that react/jsx-runtime should exist, right? Or are you saying it does exist, and so therefore this is the correct fix?
Or are you saying it does exist, and so therefore this is the correct fix?
This. Previously you were inlining react/jsx-runtime. Either you inline all entrypoints or none. Just inlining a few (here: just the JSX entrypoint), is bad.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the new jsx transform was introduced, a copy of the JSX runtime started getting included in the
index.esm.jsbundle. Including this copy meant that we could no longer swap out that module when building our own downstream Preact project. In effect, it broke Preact support.To fix this, I've updated the
rollupconfig to treatreact/jsx-runtimeas an external dependency. By externalizing the JSX runtime in this project, it 1) reduces the library bundle size by 32% and 2) allows downstream projects to use whatever JSX runtime they want.Type of Change
Could possibly be considered a breaking change, but I don't know the landscape of dependent projects well enough to know if that's true.
Checklist
Before submitting your pull request, please make sure the following is done:
Linked Issues
If this PR addresses any existing issues, please link them here. Example:
Fixes #123Test Plan
You can test that it removes the runtime by searching for the
jsxDEVfunction indist/index.esm.jsbefore and after the change. You can also see that the file size changed from144KBto97KB.I can also create a branch in my downstream project for testing upon request.