Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Add support for props that exist on downstream providers whose props are derived from prop spreading #2073

Merged

Conversation

union-zakbutcher
Copy link
Contributor

Description

Fix for #2072

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Before submitting your pull request, please make sure the following is done:

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have followed the coding guidelines in this project
  • I have tested my changes on different browsers and screen sizes

Linked Issues

Fixes #2072

Test Plan

I have a project that relies on this repo and I'm currently casting RootProvider as any to avoid this. If this does not resolve the issue I am dedicated to a fix because I like to avoid any at ALL costs

Further Comments

Candidly, I don't know if this will definitely fix the issue, but it silenced any warning / errors on my local machine in VS Code

@union-zakbutcher union-zakbutcher changed the title Add support for props that exist on downstream providers whose props are derived from prop spreading fix(types): Add support for props that exist on downstream providers whose props are derived from prop spreading Mar 13, 2024
@gpbl gpbl self-requested a review April 16, 2024 00:24
@gpbl gpbl merged commit 7dcdd95 into gpbl:main Apr 16, 2024
11 of 12 checks passed
@gpbl
Copy link
Owner

gpbl commented Apr 16, 2024

Thanks @zakbutcher, looks good to me - indeed the RootContext should have inherited those props too. Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RootContext is missing pass-through types for each context it provides
2 participants