Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo #1984

Merged
merged 1 commit into from
Dec 2, 2023
Merged

docs: fix typo #1984

merged 1 commit into from
Dec 2, 2023

Conversation

toby-brilliant
Copy link
Contributor

@toby-brilliant toby-brilliant commented Nov 30, 2023

Context

There are only 7 days in a week, so either the actual range is 0-6 or Sunday is both day 0 and 7

Analysis

Trying this out, I don't believe days higher than 6 do anything. Updating the comment to reflect the valid range.

Solution

Update the comment

### Context

There are only 7 days in a week, so either the actual range is 0-6 or Sunday is both day 0 and 7

### Analysis

Trying this out, I don't believe days higher than 6 do anything. Updating the comment to reflect the valid range.

### Solution

Update the comment
@gpbl gpbl changed the title 7 day week instead of 8 docs; fix typo Dec 2, 2023
@gpbl gpbl changed the title docs; fix typo docs: fix typo Dec 2, 2023
@gpbl
Copy link
Owner

gpbl commented Dec 2, 2023

Thanks!

@gpbl gpbl merged commit 7ddf1a1 into gpbl:main Dec 2, 2023
11 of 14 checks passed
@gpbl gpbl added the docs Documentation only changes label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation only changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants