Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow to set the selected style color #1922

Closed
ziemkowski opened this issue Oct 5, 2023 · 0 comments · Fixed by #1931
Closed

feature: allow to set the selected style color #1922

ziemkowski opened this issue Oct 5, 2023 · 0 comments · Fixed by #1931
Assignees
Labels
bug Bug or Bug fixes new feature

Comments

@ziemkowski
Copy link

Bug description

The day_selected style has a hard coded value of white.

It should use an easy-to override CSS variable, in case the user wants to use --rdp-accent-color: white; or some other bright value (such as yellow) on a dark-themed page.

To reproduce

Fork this CodeSandbox: https://codesandbox.io/s/react-day-picker-8-vl4ry with the code to reproduce the issue.

The above link fails to load for me (JS error in the console).

Steps

  1. View the source code.

Expected behavior

I would expect to be able to define a var such as --rdp-accent-text-color: black

Screenshots

image

Additional context

While I'd never use such a color combination, our users can customize their page colors and we've seen plenty of users pick surprising color combinations and I expect us to receive bug reports if we don't use their primary button colors for the selected date.

@ziemkowski ziemkowski added the bug Bug or Bug fixes label Oct 5, 2023
@gpbl gpbl changed the title Bug: Style has hard-coded color value feature: allow to set the selected style color Oct 13, 2023
@gpbl gpbl self-assigned this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or Bug fixes new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants