Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTP when accessing UNC thumbnail #1275

Closed
5 tasks done
WorldEntityGravity opened this issue Oct 30, 2023 · 1 comment
Closed
5 tasks done

FTP when accessing UNC thumbnail #1275

WorldEntityGravity opened this issue Oct 30, 2023 · 1 comment
Labels
bug Something isn't working released

Comments

@WorldEntityGravity
Copy link

WorldEntityGravity commented Oct 30, 2023

Steps to reproduce

  1. Use a UNC path for a library
  2. Place a "folder.jpg" or "cover.jpg" thumbnail file in a series folder in the library
  3. Update library / Analyze the series

Expected behavior

Komga should use a normal file transfer protocol when accessing thumbnails, like SMB or similar.

Actual behavior

It looks like Komga attempts to use FTP to access the thumbnail and in my case the NAS blocked the Komga server due to too many incorrect logins resulting in the entire media server crashing, fun times.

Logs

2023-10-30T14:11:12.459+01:00 ERROR 13824 --- [taskProcessor-1] o.g.k.domain.service.ThumbnailLifecycle  : Could not fix thumbnail: ThumbnailSeries(thumbnail=null, url=file://192.168.X.X/Media/Comics/Mousou%20Telepathy/Cover.jpg, selected=true, type=SIDECAR, mediaType=, fileSize=0, dimension=Dimension(width=0, height=0), id=0E1XXG5PG6FGK, seriesId=05J6N7P8AHZEC, createdDate=2023-10-29T21:35:24, lastModifiedDate=2023-10-29T21:35:24)
sun.net.ftp.FtpLoginException: Invalid username/password
	at java.base/sun.net.www.protocol.ftp.FtpURLConnection.connect(FtpURLConnection.java:335) ~[na:na]
	at java.base/sun.net.www.protocol.ftp.FtpURLConnection.getInputStream(FtpURLConnection.java:420) ~[na:na]
	at java.base/java.net.URL.openStream(URL.java:1317) ~[na:na]
	at org.gotson.komga.domain.service.ThumbnailLifecycle.getMetadata(ThumbnailLifecycle.kt:154) ~[classes!/:1.6.4]
	at org.gotson.komga.domain.service.ThumbnailLifecycle.access$getMetadata(ThumbnailLifecycle.kt:26) ~[classes!/:1.6.4]
	at org.gotson.komga.domain.service.ThumbnailLifecycle$fixThumbnailMetadataSeries$2.invoke(ThumbnailLifecycle.kt:72) ~[classes!/:1.6.4]
	at org.gotson.komga.domain.service.ThumbnailLifecycle$fixThumbnailMetadataSeries$2.invoke(ThumbnailLifecycle.kt:66) ~[classes!/:1.6.4]
	at org.gotson.komga.domain.service.ThumbnailLifecycle.fixThumbnailMetadata(ThumbnailLifecycle.kt:129) ~[classes!/:1.6.4]
	at org.gotson.komga.domain.service.ThumbnailLifecycle.fixThumbnailMetadataSeries(ThumbnailLifecycle.kt:66) ~[classes!/:1.6.4]
	at org.gotson.komga.domain.service.ThumbnailLifecycle.fixThumbnailsMetadata(ThumbnailLifecycle.kt:42) ~[classes!/:1.6.4]
	at org.gotson.komga.application.tasks.TaskHandler.handleTask(TaskHandler.kt:177) ~[classes!/:1.6.4]
	at org.gotson.komga.application.tasks.TaskProcessor.takeAndProcess(TaskProcessor.kt:60) ~[classes!/:1.6.4]
	at org.gotson.komga.application.tasks.TaskProcessor.processAvailableTask$lambda$2(TaskProcessor.kt:49) ~[classes!/:1.6.4]
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[na:na]
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[na:na]
	at java.base/java.lang.Thread.run(Thread.java:1623) ~[na:na]

Komga version

1.6.4 / 1.7.0

Operating system

Windows 11

Other details

Tested on both 1.6.4 and 1.7.0.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have checked the FAQ.
  • I have updated the app to the latest version.
  • I will fill out all of the requested information in this form.
@gotson gotson added bug Something isn't working and removed triage labels Oct 31, 2023
@gotson gotson closed this as completed in 879366b Oct 31, 2023
Copy link
Contributor

github-actions bot commented Nov 3, 2023

🎉 This issue has been resolved in 1.7.1 (Release Notes)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

2 participants