Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unread" filter should only show unread series and not "in progress" series #1234

Closed
4 tasks done
PhilippKammann opened this issue Sep 22, 2023 · 10 comments
Closed
4 tasks done
Labels
enhancement New feature or request released WebUI Need works in the WebUI

Comments

@PhilippKammann
Copy link

Describe your suggested feature

If you activate the "Unread" filter in the series view, Komga will show unread series and "in progress" series.
I would like if it only showed actually unread series as "in progress" has a it's own filter, that you can activate.

In API terms:

  • Currently the filter to this

    • Unread: /api/v1/series?read_status=UNREAD&read_status=IN_PROGRESS
    • In Progress: /api/v1/series?read_status=IN_PROGRESS
    • Unread & In Progress: /api/v1/series?read_status=IN_PROGRESS&read_status=UNREAD&read_status=IN_PROGRESS
  • And I would like

    • Unread: /api/v1/series?read_status=UNREAD
    • In Progress: /api/v1/series?read_status=IN_PROGRESS
    • Unread & In Progress: /api/v1/series?read_status=UNREAD&read_status=IN_PROGRESS

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have updated the app to the latest version.
  • I will fill out all of the requested information in this form.
@gotson
Copy link
Owner

gotson commented Sep 23, 2023

Is that a dashboard question or an api question?

@PhilippKammann
Copy link
Author

Dashboard. About the filtered view in the Series Browse tab.

The api calls I wrote are what the Dashboard calls for these filters

@gotson
Copy link
Owner

gotson commented Sep 23, 2023

This is actually a feature and done on purpose.

@PhilippKammann
Copy link
Author

But then checking the box "Unread" shows the same as checking "Unread" & "In Progress". Shouldn't two different filter settings do something differently? And there is no possible way to filter "unread, but not in progress" in the webui browse tab currently

@gotson
Copy link
Owner

gotson commented Sep 25, 2023

it was done as part of #526, the behaviour is modelled around other apps of the same kind.

For example in Plex, if you select "unplayed" as the filter, it would still show all the series for which you have watched some episodes.

@gotson gotson added question Further information is requested and removed triage labels Sep 25, 2023
@PhilippKammann
Copy link
Author

My request would be to have a filter to show only totally unread series. Currently thats not possible in the series browse view.

"In progress" is already a separate toggle in the ui, so it would be nice of I could toogle its inclusion in the "unread" filter and not have it always be part of it.

The api already works that way, meaning api(unread) ≠ webui(unread) which adds further confusion for me

@gotson
Copy link
Owner

gotson commented Sep 25, 2023

My request would be to have a filter to show only totally unread series. Currently thats not possible in the series browse view.

what's the use case ?

@PhilippKammann
Copy link
Author

I wanted to read someting fresh and filtered for "unread", but still needed to manually shift trough all my "in progress" series.
If I had wanted to read them, I would had just resumed them from On Deck

@gotson
Copy link
Owner

gotson commented Sep 25, 2023

I did some git archeology, and #526 was implemented at the time there was only a single "Unread" filter in both the book and series views. The "In Progress" and "Read" filters have been added later on.

Let's harmonize the filters in the webui :)

@gotson gotson added enhancement New feature or request WebUI Need works in the WebUI and removed question Further information is requested labels Sep 25, 2023
@gotson gotson closed this as completed in 8ff6694 Sep 25, 2023
@gotson gotson added the released label Oct 4, 2023
@gotson
Copy link
Owner

gotson commented Oct 4, 2023

🎉 This issue has been resolved in v1.5.0 (Release Notes)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request released WebUI Need works in the WebUI
Projects
None yet
Development

No branches or pull requests

2 participants