Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account the mime types accepted by the page API via the Accept header. #1219

Closed
4 tasks done
hgourvest opened this issue Sep 11, 2023 · 1 comment
Closed
4 tasks done
Assignees
Labels
enhancement New feature or request released

Comments

@hgourvest
Copy link

Describe your suggested feature

This request only concerns the following end point: /api/v1/books/{bookId}/pages/{pageNumber}

I would like this API to be able to return a page in PDF format if the document is a PDF and the mime type "application/pdf" appears first in the list of mime types accepted by the client in the Accept header.
for example:

Accept: application/pdf, image/*

This will allow me to continue to communicate with older versions of the server.

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have updated the app to the latest version.
  • I will fill out all of the requested information in this form.
@gotson gotson added enhancement New feature or request and removed triage labels Sep 11, 2023
@gotson gotson self-assigned this Sep 11, 2023
@gotson gotson closed this as completed in a2761f1 Sep 14, 2023
@gotson gotson added the released label Oct 4, 2023
@gotson
Copy link
Owner

gotson commented Oct 4, 2023

🎉 This issue has been resolved in v1.5.0 (Release Notes)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

2 participants