Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Auto-Delete Remaining" button for Duplicate Pages #1147

Closed
4 tasks done
PhilippKammann opened this issue Jun 30, 2023 · 7 comments
Closed
4 tasks done

"Auto-Delete Remaining" button for Duplicate Pages #1147

PhilippKammann opened this issue Jun 30, 2023 · 7 comments
Labels
enhancement New feature or request released WebUI Need works in the WebUI

Comments

@PhilippKammann
Copy link

Describe your suggested feature

A new button like the "Ignore Remaining" button added in v1.1.0 but for quickly setting all shown hashes to auto-delete

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have updated the app to the latest version.
  • I will fill out all of the requested information in this form.
@gotson
Copy link
Owner

gotson commented Jun 30, 2023

I am not very inclined to add this. There's gonna be much more pages to ignore than pages to delete i believe.

@gotson gotson added consider Not sure yet if this makes sense or not WebUI Need works in the WebUI and removed triage labels Jun 30, 2023
@PhilippKammann
Copy link
Author

I know that it is niche but it would be very helpful for my workflow and I don't think it would be detrimental for anyone else

@gotson
Copy link
Owner

gotson commented Jun 30, 2023

it's just a bit more risky IMO, mass ignoring doesn't have side effects, misclicking on auto delete by error and getting 50 pages in auto delete is a bit more dangerous.

why can't your workflow work with first choosing the pages to delete, then ignore the rest ?

@PhilippKammann
Copy link
Author

Manga/manwha scanlators normally add a unique credit page with a chapter number as the first page.
My downloader duplicates the first page of a new chapter so I can use Komgas duplicate pages feature to delete the credits.

My workflow is then to ignore the 1 or 2 duplicates that are not credit pages and auto-delete everything else.
Probably niche but most effective way I found to delete the credit pages.

Misclicking would be a problem, but Komga only deletes after the next scan so there is sitll a failsafe. Maybe add a some kind of conformation for auto-delte remaining?

@gotson
Copy link
Owner

gotson commented Jun 30, 2023

My downloader duplicates the first page of a new chapter so I can use Komgas duplicate pages feature to delete the credits.

why doesn't it delete it instead ? 🙃

Maybe add a some kind of conformation for auto-delte remaining?

probably need yes

@PhilippKammann
Copy link
Author

PhilippKammann commented Jun 30, 2023

why doesn't it delete it instead ? 🙃

Sometimes they don't put in a credit page as the first page and short of training a neural networks for image recognition I have no idea how to check that.
So I use the duplicate-pages tab to check before deleting

@gotson gotson added enhancement New feature or request and removed consider Not sure yet if this makes sense or not labels Jun 30, 2023
@gotson gotson closed this as completed in e9135fb Jul 12, 2023
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in v1.2.0 (Release Notes)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request released WebUI Need works in the WebUI
Projects
None yet
Development

No branches or pull requests

2 participants