Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Number "0" not possible in bulk edit dialogue #1057

Closed
5 tasks done
PhilippKammann opened this issue Jan 27, 2023 · 1 comment
Closed
5 tasks done

Sort Number "0" not possible in bulk edit dialogue #1057

PhilippKammann opened this issue Jan 27, 2023 · 1 comment
Assignees
Labels
bug Something isn't working released WebUI Need works in the WebUI

Comments

@PhilippKammann
Copy link

PhilippKammann commented Jan 27, 2023

Steps to reproduce

  1. Select multiple books in a series, where one of the sort numbers is "0"
  2. Open "Bulk edit metadata"
  3. Try to save while sort number is "0"

Expected behavior

Sort number is saved as "0" and the edit dialogue is closed

Actual behavior

Sort number "0" is rejeected with the error message "required".
grafik

Logs

No response

Komga version

v0.160.0-master

Operating system

Docker

Other details

If the existing sort number is something different than "0", it can be changed and saved as "0" in the dialogue without error. Only exting "0"s are the problem.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have checked the FAQ.
  • I have updated the app to the latest version.
  • I will fill out all of the requested information in this form.
@gotson
Copy link
Owner

gotson commented Jan 27, 2023

In addition, using the increment / decrement to change a number to 0 will trigger the same validation rule, but not direct input.

@gotson gotson added bug Something isn't working WebUI Need works in the WebUI and removed triage labels Jan 27, 2023
@gotson gotson self-assigned this Jan 30, 2023
@gotson gotson closed this as completed in 4385f05 Jan 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working released WebUI Need works in the WebUI
Projects
None yet
Development

No branches or pull requests

2 participants