Skip to content

Commit 6f26c2c

Browse files
committed
feat(webui): display page size in book import dialog
1 parent 432ed4e commit 6f26c2c

File tree

5 files changed

+24
-13
lines changed

5 files changed

+24
-13
lines changed

Diff for: komga-webui/src/components/PagesTable.vue

+12-8
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,17 @@
33
<thead>
44
<tr>
55
<th>{{ $t('dialog.transient_book_details.pages_table.index') }}</th>
6-
<th>{{ $t('dialog.transient_book_details.pages_table.filename') }}</th>
7-
<th>{{ $t('dialog.transient_book_details.pages_table.media_type') }}</th>
8-
<th>{{ $t('dialog.transient_book_details.pages_table.width') }}</th>
9-
<th>{{ $t('dialog.transient_book_details.pages_table.height') }}</th>
6+
<th :class="rightPages.length > 0 ? 'diff' : ''">{{ $t('dialog.transient_book_details.pages_table.filename') }}</th>
7+
<th :class="rightPages.length > 0 ? 'diff' : ''">{{ $t('dialog.transient_book_details.pages_table.media_type') }}</th>
8+
<th :class="rightPages.length > 0 ? 'diff' : ''">{{ $t('dialog.transient_book_details.pages_table.width') }}</th>
9+
<th :class="rightPages.length > 0 ? 'diff' : ''">{{ $t('dialog.transient_book_details.pages_table.height') }}</th>
10+
<th :class="rightPages.length > 0 ? 'diff' : ''">{{ $t('dialog.transient_book_details.pages_table.size') }}</th>
1011
<template v-if="rightPages.length > 0">
1112
<th>{{ $t('dialog.transient_book_details.pages_table.filename') }}</th>
1213
<th>{{ $t('dialog.transient_book_details.pages_table.media_type') }}</th>
1314
<th>{{ $t('dialog.transient_book_details.pages_table.width') }}</th>
1415
<th>{{ $t('dialog.transient_book_details.pages_table.height') }}</th>
16+
<th>{{ $t('dialog.transient_book_details.pages_table.size') }}</th>
1517
</template>
1618
</tr>
1719
</thead>
@@ -21,15 +23,17 @@
2123
:key="i"
2224
>
2325
<td>{{ n }}</td>
24-
<td>{{ $_.get(leftPages[n-1], 'fileName', '') }}</td>
25-
<td>{{ $_.get(leftPages[n-1], 'mediaType', '') }}</td>
26-
<td>{{ $_.get(leftPages[n-1], 'width', '') }}</td>
27-
<td>{{ $_.get(leftPages[n-1], 'height', '') }}</td>
26+
<td :class="rightPages.length > 0 ? 'diff' : ''">{{ $_.get(leftPages[n-1], 'fileName', '') }}</td>
27+
<td :class="rightPages.length > 0 ? 'diff' : ''">{{ $_.get(leftPages[n-1], 'mediaType', '') }}</td>
28+
<td :class="rightPages.length > 0 ? 'diff' : ''">{{ $_.get(leftPages[n-1], 'width', '') }}</td>
29+
<td :class="rightPages.length > 0 ? 'diff' : ''">{{ $_.get(leftPages[n-1], 'height', '') }}</td>
30+
<td :class="rightPages.length > 0 ? 'diff' : ''">{{ $_.get(leftPages[n-1], 'size', '') }}</td>
2831
<template v-if="rightPages.length > 0">
2932
<td>{{ $_.get(rightPages[n-1], 'fileName', '') }}</td>
3033
<td>{{ $_.get(rightPages[n-1], 'mediaType', '') }}</td>
3134
<td>{{ $_.get(rightPages[n-1], 'width', '') }}</td>
3235
<td>{{ $_.get(rightPages[n-1], 'height', '') }}</td>
36+
<td>{{ $_.get(rightPages[n-1], 'size', '') }}</td>
3337
</template>
3438
</tr>
3539
</tbody>

Diff for: komga-webui/src/components/dialogs/TransientBookDetailsDialog.vue

+5-5
Original file line numberDiff line numberDiff line change
@@ -19,32 +19,32 @@
1919
<thead v-if="rightBook">
2020
<tr>
2121
<th></th>
22-
<th>{{ $t('dialog.transient_book_details.label_candidate') }}</th>
22+
<th :class="rightBook ? 'diff' : ''">{{ $t('dialog.transient_book_details.label_candidate') }}</th>
2323
<th>{{ $t('dialog.transient_book_details.label_existing') }}</th>
2424
</tr>
2525
</thead>
2626
<tbody>
2727
<tr>
2828
<td class="font-weight-medium">{{ $t('dialog.transient_book_details.label_name') }}</td>
29-
<td>{{ leftBook.name }}</td>
29+
<td :class="rightBook ? 'diff' : ''">{{ leftBook.name }}</td>
3030
<td v-if="rightBook">{{ rightBook.metadata.title }}</td>
3131
</tr>
3232

3333
<tr>
3434
<td class="font-weight-medium">{{ $t('dialog.transient_book_details.label_size') }}</td>
35-
<td>{{ leftBook.size }}</td>
35+
<td :class="rightBook ? 'diff' : ''">{{ leftBook.size }}</td>
3636
<td v-if="rightBook">{{ rightBook.size }}</td>
3737
</tr>
3838

3939
<tr>
4040
<td class="font-weight-medium">{{ $t('dialog.transient_book_details.label_format') }}</td>
41-
<td>{{ getBookFormatFromMediaType(leftBook.mediaType).type }}</td>
41+
<td :class="rightBook ? 'diff' : ''">{{ getBookFormatFromMediaType(leftBook.mediaType).type }}</td>
4242
<td v-if="rightBook">{{ getBookFormatFromMediaType(rightBook.media.mediaType).type }}</td>
4343
</tr>
4444

4545
<tr>
4646
<td class="font-weight-medium">{{ $t('dialog.transient_book_details.label_pages') }}</td>
47-
<td>{{ leftBook.pages.length }}</td>
47+
<td :class="rightBook ? 'diff' : ''">{{ leftBook.pages.length }}</td>
4848
<td v-if="rightBook">{{ rightBook.media.pagesCount }}</td>
4949
</tr>
5050

Diff for: komga-webui/src/locales/en.json

+1
Original file line numberDiff line numberDiff line change
@@ -505,6 +505,7 @@
505505
"height": "Height",
506506
"index": "Index",
507507
"media_type": "Media type",
508+
"size": "Size",
508509
"width": "Width"
509510
},
510511
"title": "Book Details",

Diff for: komga-webui/src/plugins/vuetify.ts

+2
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ export default new Vuetify({
3434
accent: '#ff0335',
3535
'contrast-1': colors.grey.lighten4,
3636
'contrast-light-2': colors.grey.darken2,
37+
'diff': colors.green.lighten4,
3738
},
3839
dark: {
3940
base: colors.shades.black,
@@ -42,6 +43,7 @@ export default new Vuetify({
4243
accent: '#ff0335',
4344
'contrast-1': colors.grey.darken4,
4445
'contrast-light-2': colors.grey.lighten2,
46+
'diff': colors.green.darken4,
4547
},
4648
},
4749
},

Diff for: komga-webui/src/types/komga-books.ts

+4
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ export interface PageDto {
3333
mediaType: string,
3434
width?: number,
3535
height?: number,
36+
sizeBytes?: number,
37+
size: string,
3638
}
3739

3840
export interface PageDtoWithUrl {
@@ -41,6 +43,8 @@ export interface PageDtoWithUrl {
4143
mediaType: string,
4244
width?: number,
4345
height?: number,
46+
sizeBytes?: number,
47+
size: string,
4448
url: string,
4549
}
4650

0 commit comments

Comments
 (0)