-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SolidJS #471
Comments
In case anyone wants something to read while they wait. A Solid RealWorld Demo Comparison of JavaScript Framework Performance. |
very good article. and i want to solidify my js knowledge, if you know what i mean) solidjs is the next framework in my wishlist to learn right behind React, Angilar and even Preact! Keep it going, ya cross go da fingers to have this new fw a green light in MIcrosoft or Google (or Alibaba, to be honest)! |
@ryansolid every lighthouse update seems to stray farther from what i'm seeing in the perf recording timeline, too. it's gotten to the point where i don't trust it anymore. things that used to score 75 in perf are now scoring 95, but the timeline still clearly shows a large difference. |
This is great @ryansolid! Would you be willing to add CI (e.g Travis/Circle) to demonstrate building the repo? That would be super. |
@anishkny Cool I set it up to build with travis and deploy to the github pages. Had to configure rollup differently to make it clean, and now seem to be stuck with an entry js file that just imports the actual entry but it's only a 200byte weight so I will live for now until I figure it out. In any case CI now fully working. |
Ended up not mattering much new version of Solid shrinks the bundle more. We now are at 11.1kb on initial load. So I think the size is at a reasonable place. Look forward to your review. |
@anishkny @EricSimons I don't want to be that guy because I can only imagine the overhead of maintaining a repo of this size. But it's been a few months and I was wondering if there was anything more I could do to help push push this along. |
Please add SolidJS. I'm really looking forward to the 2020 update of |
I think this would be a solid addition to the list |
I am now ready to learn this Solid frontend framework. Though it's now behind mikado in the bechmark but it's more active. |
@Dan-Do Glad to hear your interest. Solid and Mikado differ in a few ways other than performance as Solid offers more higher level features, and the approach Solid uses in the benchmark scales beyond tying data to a single template. I do think Mikado has really pushed the envelope though so I look forward to competing with it again when their benchmark implementation is fixed to be properly keyed. |
@anishkny @EricSimons I will ask again if there is something I can do to help this along. I do understand this is just a matter of not really having time to review any implementations and I'm not in any real rush. But I'd love to get in before the comparison article goes out next year. I just missed the cycle of merges that got in this years article. But I'd love to be able to have Solid in next years. |
would really love to see this in as well |
Looking forward to seeing Solid implementation here, so much potential in that lib. |
Well looks like I got us added to the new website. So I will see how this plays out as it is released and close the issue here if appropriate. But it's something. See it here: https://realworld.mvila.me/ |
Maybe creating a PR with it (referencing this issue) would make it easier for them? Also, remember: "we require a minimum of one unit test with every repo" https://github.com/gothinkster/realworld/tree/master/spec |
+1 for adding Solid here... |
Hi, @ryansolid! Apologies for the delay in reviewing your implementation, the maintenance team had very limited availability and we've recruited new members to help with the project. I've added your implementation to the list of frontends (#601). The README should be autogenerated within 24 hours. |
I've put together a Realworld Demo for Solid(https://github.com/ryansolid/solid), the top-performing reactive library on from the JS Framework Benchmark.
This demo includes a modern implementation is clientside only using code-splitting and Suspense with data-fetching.
You can find the repo here: https://github.com/ryansolid/solid-realworld.
I look forward to this being added.
The text was updated successfully, but these errors were encountered: