Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASP.NET Core Using Functional Programming with C# #270

Closed
5 of 6 tasks
dnikolovv opened this issue Sep 21, 2018 · 11 comments
Closed
5 of 6 tasks

ASP.NET Core Using Functional Programming with C# #270

dnikolovv opened this issue Sep 21, 2018 · 11 comments

Comments

@dnikolovv
Copy link
Contributor

dnikolovv commented Sep 21, 2018

Current Status

postman-tests

newman-tests

Todo:

  • 🏁 Fork the starter repo & post the link in this issue
  • 🔨 Implement all of Conduit's functionality per the spec & API
  • 💬 Complete the README file
  • 🎨 Create logo for repo & update issue status (@EricSimons )
  • 👀 Peer review of final codebase by RealWorld admins & community (RFC)
  • 🎉 Tag v1 release, move repo to main org, and officially list it on the README!

Get involved!

Help increase the test coverage. dnikolovv/dev-adventures-realworld/tests
Complete issues via Pull Requests or more add issues! dnikolovv/dev-adventures-realworld/issues

Background

This was done as there are very few examples of real applications written using functional C# and this can serve as a general guideline. The overall architecture is taken from the Dev Adventures .NET Core template.

I am aware of Adam Hathcock's .NET Core implementation and I think it is great, but the differences between the two are so significant that they should be viewed upon as completely different implementations.

@lastlink
Copy link

I would also like to see one using a micro framwork like nancy (ruby has sinatra & python has flask)

@dnikolovv
Copy link
Contributor Author

You're definitely right! I'll take up on that soon.

@dmytrohridin
Copy link

@lastlink @dnikolovv ther is already repository for Nancy and issue
#123

By the way @dnikolovv your implementation is very excited!

@dnikolovv
Copy link
Contributor Author

Hey @anishkny. Since all tests are passing now, may we move this one into a "review" stage?

@anishkny
Copy link
Member

anishkny commented Oct 9, 2018

@dnikolovv would it be possible have build/test setup in something like TravisCI or AppVeyor?

@dnikolovv
Copy link
Contributor Author

@anishkny Of course! I've added TravisCI.

@dnikolovv
Copy link
Contributor Author

Hey guys,

It's been a few months now. I've set the Travis build to run the Postman tests and everything appears to be working correctly. Do you think we should be moving this one into the official Readme?

@anishkny
Copy link
Member

anishkny commented Jan 8, 2019

@dnikolovv looks good to me. Great work. Do you want to send a PR adding your repo to: etc/backend-repos.yaml. Thanks!

@lastlink
Copy link

lastlink commented Jan 8, 2019

I think that this may have the issues that many other WIP have and are missing, updating an article & tags.

@dnikolovv
Copy link
Contributor Author

@lastlink Updating an article together with its tags works as intended. Are there any other "tricky" parts that I could check?

@anishkny I've submitted a PR.

@anishkny
Copy link
Member

anishkny commented Jan 8, 2019

Added

@anishkny anishkny closed this as completed Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants