Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: about package name #8

Closed
thinkerou opened this issue Aug 29, 2018 · 4 comments
Closed

question: about package name #8

thinkerou opened this issue Aug 29, 2018 · 4 comments

Comments

@thinkerou
Copy link

thinkerou commented Aug 29, 2018

Hi, @wangzitian0 @EricSimons
I found the repo come from your personal repo https://github.com/wangzitian0/golang-gin-starter-kit, so, if your personal repo no longer maintain please mark as warning and redirect here.
Because I want to learn/use and commit pull request, but I don't know commit where, thanks!

BTW, if you permit, we should link the repo to gin readme.

@wangzitian
Copy link

Hi, @thinkerou ,
The codes of two repo are same now, doc has a little different.
In general, gothinkster's repo is enough, but the management of golang package in this project was not very well yet, even some package path in gothinkster's repo was using my personal repo full path...
I think before the warning, we should:

  1. Modify & check the import path in gothinkster's repo, better using relative path.
  2. Make sure the two repo has no rely relationship..
  3. Duplicate my personal repo.

Welcome to do the step1 &step2, thanks, hhhh

@wangzitian0
Copy link
Collaborator

@EricSimons Hi, Eric,
Could you please help adding the travis CI app to https://github.com/gothinkster/golang-gin-realworld-example-app or add me to the gothinkster organization temporarily? I used to using my personal project to do that, for long term consideration, #10 was duplicating the rely relationship..
Thank you!

@wangzitian0
Copy link
Collaborator

@EricSimons Friendly ping.

@wangzitian0
Copy link
Collaborator

In general, the operation should be:
In https://github.com/marketplace/category/continuous-integration add Codecov and Travis CI.
In https://github.com/marketplace/travis-ci, click Configure access .
Then, click the configure of Codecov and Travis CI, give them permission.

Or add me to the gothinkster organization temporarily?
Thank you very much, Eric! @EricSimons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants