Skip to content
This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

Typescript of interest? #25

Open
4imble opened this issue May 17, 2018 · 12 comments
Open

Typescript of interest? #25

4imble opened this issue May 17, 2018 · 12 comments

Comments

@4imble
Copy link

4imble commented May 17, 2018

I forked the project, created a new Aurelia application within using TypeScript and then copied over and converted all the JS files to TypeScript a couple of weeks ago. I did not go as far as setting all the Types, but only did the ones that were obvious or needed to be fixed up as part of the conversion.

I will ultimately be using my fork as a foundation to build my own real blog but wondered if it would be of use.

@loaded02
Copy link
Collaborator

Yes of course. Sounds good. Since we cant merge your fork, what would you think if we have a link to your fork in the readme?

@loaded02
Copy link
Collaborator

@4imble I added your project to the readme. Thank you very much!!!

@loaded02
Copy link
Collaborator

loaded02 commented Jun 2, 2018

@4imble do you want to create a pr to a typescript branch?

@loaded02 loaded02 reopened this Jun 2, 2018
@4imble
Copy link
Author

4imble commented Jun 2, 2018

Maybe, I have contacted you in gitter if you'd like to chat about it :)

@4imble
Copy link
Author

4imble commented Jun 7, 2018

I'm happy to merge in my fork and I'll try and keep it up to date as changes go into master. Thinking about it, I suspect there wont be too many as only bug fixes and optimisations should only be going in, not new features.

I'll try and get the changes that have happened so far in and do the pull request this week.

@4imble
Copy link
Author

4imble commented Jun 8, 2018

As i mentioned in the pull request you have waiting, do you want me to also convert to webpack?

@loaded02
Copy link
Collaborator

loaded02 commented Jun 8, 2018

Hi @4imble! Sorry for the delayed reply. It looks like I will do that. Size is smaller. I wanted to do a speed comparisson before I merge. But I am pretty sure we gonna change to wp. Thanks for your work.

@4imble
Copy link
Author

4imble commented Jun 11, 2018

No need to apologise, we're all busy :)
I stay after work to do personal projects on Tuesday, I'll dedicate some time to updating to WP and bringing in the new changes since my fork. Cheers 👍

@4imble
Copy link
Author

4imble commented Jul 17, 2018

Enough has changed that it's probably easier for me to do the conversion on each file from scratch again.
Also, I'm not sure how best to keep the two branches updated without manually applying each commit. I've been pretty slow, but is it worth holding off even longer and then doing the conversion when we think it's all done 99% and unlikely to change?

@loaded02
Copy link
Collaborator

loaded02 commented Jul 23, 2018 via email

@4imble
Copy link
Author

4imble commented Sep 4, 2018

Looks like the changes are quite settled now. Do you want to make me a contributor to the typescript branch? I'll have a go at updating it again with the latest changes. Cheers 👍

@loaded02
Copy link
Collaborator

@4imble please feel free to make a pr to the typescript branch. This way you‘ll become a contributor. Thanks for your work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants