Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map access via primary character inheritance #5

Closed
3 tasks
samoneilll opened this issue Jul 24, 2021 · 3 comments
Closed
3 tasks

Map access via primary character inheritance #5

samoneilll opened this issue Jul 24, 2021 · 3 comments

Comments

@samoneilll
Copy link

samoneilll commented Jul 24, 2021

Goal:

A member of a corporation/alliance should be able to add an out of corp alt. This alt can then log in and get the same map access as the main it is linked to.

Case Description:

Background:

  • Bob is a member of ACME corporation that has a corporation map.
  • ACME corp is a member of the QQQ alliance which has an alliance map.
  • Bob wants to be able to probe and map chains using his npc corp alt Alice.

Case:

  • Character Bob logs in to PF

  • A new user is made (UserB) with Bob as the primary character

  • Bob has access to the ACME coporation map as he is a member of the corporation

  • Bob has access to the QQQ alliance map because his corp ACME is a member of QQQ

  • Bob creates a personal character map

  • Bob uses the "new character" action from the character menu to log in his alt Alice

  • Character Alice is added to the user UserB

  • Because character Alice is on the user UserB, the info for the primary character is refreshed

  • Alice can see any maps that the primary character (Bob) can see.

  • Alice gets access to the ACME corporation map, the QQQ alliance map and Bob's personal character map.
    //

  • Bob leaves ACME

  • Alice logs in to PF

  • Because character Alice is on userB, the info for the primary character is refreshed

  • Bob (with refreshed character information from ESI) can no longer view the ACME corporation map or the QQQ alliance map.

  • Alice gets access to Bob's personal character map

Things to do:

  • extend user_character model to have a "primary" column that should be set true if it is the first character to log in
    OR extend user model to have a "primary_character" column that should be set to the char id of the first character to log in
  • when a non-primary character logs in, information for the user's primary character is updated from ESI
  • when a non-primary character logs in, the character's map access is inherited from the user's primary character
@samoneilll
Copy link
Author

Not considered above:

How will an out of corp alt be granted access if PF has login restrictions in place? Should allow-list exception be granted manually via input of character ids by admin, or should exception to allow-list be granted organically during login flow?

@samoneilll
Copy link
Author

Solution we settled on was to share maps with all characters within a browser session, without making any adjustments to the map/character/user models.

@samoneilll
Copy link
Author

Solved with #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant