Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new code pushed to main branch? #182

Closed
illume opened this issue Jan 24, 2025 · 3 comments
Closed

new code pushed to main branch? #182

illume opened this issue Jan 24, 2025 · 3 comments
Labels

Comments

@illume
Copy link

illume commented Jan 24, 2025

It looks like a big commit was just pushed to the main branch without a PR.

Seems it's a bunch of commits together from a fork somewhere?

@illume illume added the bug label Jan 24, 2025
@jaitaiwan jaitaiwan added question and removed bug labels Jan 24, 2025
@jaitaiwan
Copy link

What do you mean by big commit? It's 3 files. Or bunch of commits it's a single commit? Maintainers will often push directly to the branch ourselves where required. You see the same thing on many other gorilla repos. Eventually there will be a release which will include this change and whatever others we merge or push.

@illume
Copy link
Author

illume commented Jan 24, 2025

I wondered about a commit pushed to main by a new contributor is all. I wrongly assumed code review would be done via PR because I saw an OpenSSF best practices badge.

cc @coreydaley

@coreydaley
Copy link
Contributor

Only because I was tagged by @illume I will weigh in.
All contributed code SHOULD be a pull request so that it can be reviewed by the community, unless it fixes an embargoed CVE. I am not up-to-date on the circumstances surrounding this commit.

Since this user (@patrickod) is also a first time contributor it does seem a bit weird and suspicious. Maybe that user can weigh in on the circumstances surrounding this contribution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants