Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filtering for GitHub releases. #29

Closed
d-mokliakov opened this issue Apr 30, 2022 · 3 comments
Closed

Implement filtering for GitHub releases. #29

d-mokliakov opened this issue Apr 30, 2022 · 3 comments

Comments

@d-mokliakov
Copy link

Maybe it is not a best idea (because it breaks backward compatibility) but I propose to modify config structure for GitHub mods.
From this:

"GitHubRepository": [
    "someGithubUser",
    "someRepoName"
]

To this:

"GitHubRepository": {
    "author": "someGithubUser",
    "repo": "someRepoName",
    "file_mask": ".*-release.jar$" // This parameter is a regular expression.
}
@theRookieCoder theRookieCoder changed the title Feature request: Implement filtering for GitHub releases. Implement filtering for GitHub releases. May 2, 2022
@JustSimplyKyle
Copy link
Contributor

JustSimplyKyle commented May 5, 2022

This would also help downloading this mod in 1.18, since currently ferium downloads the 1.17 version
https://github.com/xCollateral/VulkanMod/releases

@jhmaster2000
Copy link

+1 to this, Ferium currently fails to correctly install 19MisterX98/SeedcrackerX because of the *-api.jar file provided, which I assume Ferium picks because its the top one on the list. Something like:

ferium add 19MisterX98/SeedcrackerX --excludefiles "*-api.jar"

would fix it nicely. (I don't see a way to filter out the right file with an inclusion glob pattern instead of an exclusion one)

@theRookieCoder
Copy link
Collaborator

theRookieCoder commented Mar 24, 2023

Moved to #155

Let me know if the GitHub filters I have 'designed' are adequate.

@theRookieCoder theRookieCoder closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants