Skip to content

fix: bottom sheet scroll jumpy #2533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: bottom sheet scroll jumpy #2533

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fa5734
fix: take into account scrollable content offset y for panning gesture
doanhtu07 Oct 20, 2025
7cc0398
fix: use already declared variable for content offset y
doanhtu07 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/hooks/useGestureEventsHandlersDefault.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const dismissKeyboard = Keyboard.dismiss;
// biome-ignore lint: to be addressed!
const resetContext = (context: any) => {
'worklet';
Object.keys(context).map(key => {
Object.keys(context).forEach(key => {
context[key] = undefined;
});
};
Expand Down Expand Up @@ -375,11 +375,21 @@ export const useGestureEventsHandlersDefault: GestureEventsHandlersHookType =
snapPoints.unshift(closedDetentPosition);
}

const wasGestureHandledByScrollView =
source === GESTURE_SOURCE.CONTENT && scrollableContentOffsetY > 0;

let rawDestinationPosition =
translationY + context.value.initialPosition;

if (wasGestureHandledByScrollView) {
rawDestinationPosition -= scrollableContentOffsetY;
}

/**
* calculate the destination point, using redash.
*/
const destinationPoint = snapPoint(
translationY + context.value.initialPosition,
rawDestinationPosition,
velocityY,
snapPoints
);
Expand All @@ -392,8 +402,6 @@ export const useGestureEventsHandlersDefault: GestureEventsHandlersHookType =
return;
}

const wasGestureHandledByScrollView =
source === GESTURE_SOURCE.CONTENT && scrollableContentOffsetY > 0;
/**
* prevents snapping from top to middle / bottom with repeated interrupted scrolls
*/
Expand Down