Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] | [v2] Demo in documentation doesn't work: 'snapPoints' was provided with no points #1847

Closed
vliegelientje opened this issue May 28, 2024 · 7 comments
Labels
bug Something isn't working no-issue-activity

Comments

@vliegelientje
Copy link

Bug

The demo on https://ui.gorhom.dev/components/bottom-sheet/usage does not work. It seems to be missing some parameters:

Invariant Violation: 'snapPoints' was provided with no points! please provide at least one snap point.

Environment info

Library Version
@gorhom/bottom-sheet 4.6.3
react-native 0.74.1
react-native-reanimated 3.10.1
react-native-gesture-handler 2.16.2

Steps To Reproduce

  1. Installed package
  2. Followed the instructions on https://ui.gorhom.dev/components/bottom-sheet/usage

Describe what you expected to happen:

  1. See a page with bottom sheet

Reproducible sample code

@vliegelientje vliegelientje added the bug Something isn't working label May 28, 2024
@ilfoxo
Copy link

ilfoxo commented Jun 1, 2024

Same for me

@sebastianbila
Copy link

Guys, just add the snapPoints. Don't be stupid, it's easy

@sebastianbila
Copy link

sebastianbila commented Jun 3, 2024

<BottomSheet
     ref={bottomRef}
     snapPoints={['30%', '50%']}
     enablePanDownToClose
     onClose={onClose}
   >

@vliegelientje
Copy link
Author

No need to be rude. There's just so many libraries around that aren't maintained or not working anymore.
If the demo doesn't work, I don't bother to dive any further in the documentation.

@ilfoxo
Copy link

ilfoxo commented Jun 3, 2024

Just was reporting the issue in the example... Genius!

Copy link

github-actions bot commented Jul 4, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Copy link

github-actions bot commented Jul 9, 2024

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity
Projects
None yet
Development

No branches or pull requests

3 participants