Skip to content

local file:// filter lists not loading in Chromium browsers #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0strodamus opened this issue Sep 8, 2016 · 3 comments
Closed

local file:// filter lists not loading in Chromium browsers #1971

0strodamus opened this issue Sep 8, 2016 · 3 comments

Comments

@0strodamus
Copy link

0strodamus commented Sep 8, 2016

  • Browser/version: I've noticed this behavior in several different chromium-based browsers, i.e Inox 53.0.2785.89, Iridium 51.1, Vivaldi 1.3.551.38
  • uBlock Origin version: 1.9.4

Issue: I have a couple local filter lists that I use. If I add them to uBlock0's "3rd-party filters" Custom section using file:///home/username/.config/ublock0-filters/custom-filters.txt, they do not load. The filter name shows as file:///home/username/.config/ublock0-filters/custom-filters.txt and uBlock0 reports "0 used out of 0" and "out of date".

Resolution: I have found the following will allow local filter lists to load properly. Edit the uBlock0 manifest.json permissions starting at line 47, and add ,file:///*/* to the end of the list.

@lewisje
Copy link

lewisje commented Sep 9, 2016

That sounds similar to what an extension would need to do to request the permission to "Allow access to file URLs"; some extensions have that checkbox in the Extensions menu, but uBlock Origin does not.

@gorhill
Copy link
Owner

gorhill commented Sep 9, 2016

I need to add "optional_permissions": [ "file:///*" ] to the manifest.

Advantage of optional permission:

Easier upgrades: When you upgrade your extension, Chrome will not disable it for your users if the upgrade adds optional rather than required permissions.

Last time I changed permissions (added privacy to control pre-fetching, webrtc config, etc.), there was a lot of knee-jerking, i rather avoid this this time.

@0strodamus
Copy link
Author

I did a quick test with "optional_permissions": [ "file:///*" ] in the manifest (replacing the permission I added in my first post) and noticed that my filters still weren't loading. However, after I opened the extensions tab and unchecked/rechecked "Allow access to file URLs", they loaded and are continuing to load properly after restarting the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants