Mind that tabs.sendMessage can throw

gorhill · Mar 17, 2024 · 3f7374c · 3f7374c
1 parent 9146134
commit 3f7374c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/platform/chromium/webext.js b/platform/chromium/webext.js
@@ -19,8 +19,6 @@
     Home: https://github.com/gorhill/uBlock
 */
 
-'use strict';
-
 // `webext` is a promisified api of `chrome`. Entries are added as
 // the promisification of uBO progress.
 
@@ -104,6 +102,7 @@ const webext = {
         query: promisifyNoFail(chrome.tabs, 'query', tabs => Array.isArray(tabs) ? tabs : []),
         reload: promisifyNoFail(chrome.tabs, 'reload'),
         remove: promisifyNoFail(chrome.tabs, 'remove'),
+        sendMessage: promisifyNoFail(chrome.tabs, 'sendMessage'),
         update: promisifyNoFail(chrome.tabs, 'update', tab => tab instanceof Object ? tab : null),
     },
     // https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/webNavigation

diff --git a/src/js/broadcast.js b/src/js/broadcast.js
@@ -19,10 +19,6 @@
     Home: https://github.com/gorhill/uBlock
 */
 
-/* globals browser */
-
-'use strict';
-
 /******************************************************************************/
 
 // Broadcast a message to all uBO contexts
@@ -47,7 +43,7 @@ export async function broadcastToAll(message) {
     });
     const bcmessage = Object.assign({ broadcast: true }, message);
     for ( const tab of tabs ) {
-        browser.tabs.sendMessage(tab.id, bcmessage);
+        webext.tabs.sendMessage(tab.id, bcmessage).catch(( ) => { });
     }
 }