Skip to content

Commit 0870aea

Browse files
committed
code review re. #1735
1 parent 08dd67b commit 0870aea

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/js/tab.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -392,15 +392,14 @@ housekeep itself.
392392
};
393393

394394
// https://github.com/gorhill/uBlock/issues/1735
395-
// Always push before committing, to allow popup detector code to do its
396-
// job.
395+
// Filter for popups if actually committing.
397396
var commit = function(tabId, url) {
398397
var entry = tabContexts[tabId];
399398
if ( entry === undefined ) {
400399
entry = push(tabId, url);
401400
} else {
402-
entry.push(url);
403401
entry.commit(url);
402+
popupCandidateTest(tabId);
404403
}
405404
return entry;
406405
};

0 commit comments

Comments
 (0)